From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gospodarek Subject: Re: [PATCH net-next v2 09/10] bnxt_en: add support for software dynamic interrupt moderation Date: Mon, 8 Jan 2018 09:04:58 -0500 Message-ID: <20180108140458.GA87664@C02RW35GFVH8.dhcp.broadcom.net> References: <1515193094-9554-1-git-send-email-andy@greyhouse.net> <1515193094-9554-10-git-send-email-andy@greyhouse.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, mchan@broadcom.com, talgi@mellanox.com, ogerlitz@mellanox.com, Andy Gospodarek To: Vasundhara Volam Return-path: Received: from mail-qk0-f169.google.com ([209.85.220.169]:33045 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755465AbeAHOFD (ORCPT ); Mon, 8 Jan 2018 09:05:03 -0500 Received: by mail-qk0-f169.google.com with SMTP id i17so9823697qke.0 for ; Mon, 08 Jan 2018 06:05:03 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Jan 08, 2018 at 04:20:04PM +0530, Vasundhara Volam wrote: > Hi Andy, > > If you are re-doing the patch, could you modify a minor comment below? > > On Sat, Jan 6, 2018 at 4:28 AM, Andy Gospodarek wrote: > > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c > > new file mode 100644 > > index 0000000..156e025 > > --- /dev/null > > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c > > @@ -0,0 +1,32 @@ > > +/* > > + * Copyright (c) 2017 Broadcom Limited > You have to modify year here. > Also, First line driver description is missing "Broadcom NetXtreme-C/E > network driver." > Could you modify it? Sure I could make those changes since it looks like I need a v3 anyway. Thanks for the review.