From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: b43: Replace mdelay with msleep in b43_radio_2057_init_post Date: Mon, 8 Jan 2018 16:21:28 +0000 (UTC) Message-ID: <20180108162128.C4C9060B3B@smtp.codeaurora.org> References: <1514632107-14698-1-git-send-email-baijiaju1990@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: colin.king@canonical.com, johannes.berg@intel.com, tiwai@suse.de, kstewart@linuxfoundation.org, gregkh@linuxfoundation.org, andrew.zaborowski@intel.com, linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai To: Jia-Ju Bai Return-path: In-Reply-To: <1514632107-14698-1-git-send-email-baijiaju1990@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Jia-Ju Bai wrote: > b43_radio_2057_init_post is not called in an interrupt handler > nor holding a spinlock. > The function mdelay in it can be replaced with msleep, to reduce busy wait. > > Signed-off-by: Jia-Ju Bai You submitted an identical patch a week earlier: https://patchwork.kernel.org/patch/10137671/ How is this different? Also always add version number to the patch so that the maintainers can follow the changes easily: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing -- https://patchwork.kernel.org/patch/10137671/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches