From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: mt76: fix memcpy to potential null pointer on failed allocation Date: Mon, 8 Jan 2018 17:28:58 +0000 (UTC) Message-ID: <20180108172858.AB27260346@smtp.codeaurora.org> References: <20171214101322.10178-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Matthias Brugger , Lorenzo Bianconi , Felix Fietkau , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: Colin Ian King Return-path: In-Reply-To: <20171214101322.10178-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Colin Ian King wrote: > From: Colin Ian King > > Currently if the allocation of skb fails and returns NULL then the > call to skb_put will cause a null pointer dereference. Fix this by > checking for a null skb and returning NULL. Note that calls to > function mt76x2_mcu_msg_alloc don't directly check the null return > but instead pass the NULL pointer to mt76x2_mcu_msg_send which > checks for the NULL and returns ENOMEM in this case. > > Detected by CoverityScan, CID#1462624 ("Dereference null return value") > > Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") > Signed-off-by: Colin Ian King > Acked-by: Felix Fietkau Patch applied to wireless-drivers-next.git, thanks. 364bea50dbea mt76: fix memcpy to potential null pointer on failed allocation -- https://patchwork.kernel.org/patch/10111747/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches