netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mauro Carvalho Chehab <mchehab@s-opensource.com>,
	Josef Griebichler <griebichler.josef@gmx.at>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	USB list <linux-usb@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Rik van Riel <riel@redhat.com>, Paolo Abeni <pabeni@redhat.com>,
	Hannes Frederic Sowa <hannes@redhat.com>,
	Jesper Dangaard Brouer <jbrouer@redhat.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	LMML <linux-media@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	David Miller <davem@davemloft.net>
Subject: Re: dvb usb issues since kernel 4.9
Date: Mon, 8 Jan 2018 18:55:51 +0100	[thread overview]
Message-ID: <20180108175551.wp6thxmiozrz4yp2@gmail.com> (raw)
In-Reply-To: <CA+55aFzHPYuxg3LwhqcxwJD2fuKzg6wU5ypfMvrpRoioiQHDFg@mail.gmail.com>


* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Sat, Jan 6, 2018 at 11:54 AM, Mauro Carvalho Chehab
> <mchehab@s-opensource.com> wrote:
> >
> > Em Sat, 6 Jan 2018 16:04:16 +0100
> > "Josef Griebichler" <griebichler.josef@gmx.at> escreveu:
> >>
> >> the causing commit has been identified.
> >> After reverting commit https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4cd13c21b207e80ddb1144c576500098f2d5f882
> >> its working again.
> >
> > Just replying to me won't magically fix this. The ones that were involved on
> > this patch should also be c/c, plus USB people. Just added them.
> 
> Actually, you seem to have added an odd subset of the people involved.
> 
> For example, Ingo - who actually committed that patch - wasn't on the cc.
> 
> I do think we need to simply revert that patch. It's very simple: it
> has been reported to lead to actual problems for people, and we don't
> fix one problem and then say "well, it fixed something else" when
> something breaks.
> 
> When something breaks, we either unbreak it, or we revert the change
> that caused the breakage.
> 
> It's really that simple. That's what "no regressions" means.  We don't
> accept changes that cause regressions. This one did.

Yeah, absolutely - for the revert:

   Acked-by: Ingo Molnar <mingo@kernel.org>

as I doubt we have enough time to root-case this properly.

Thanks,

	Ingo

  parent reply	other threads:[~2018-01-08 17:55 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <trinity-35b3a044-b548-4a31-9646-ed9bc83e6846-1513505978471@3c-app-gmx-bs03>
     [not found] ` <20171217120634.pmmuhdqyqmbkxrvl@gofer.mess.org>
     [not found]   ` <20171217112738.4f3a4f9b@recife.lan>
     [not found]     ` <trinity-1fa14556-8596-44b1-95cb-b8919d94d2d4-1515251056328@3c-app-gmx-bs15>
2018-01-06 19:54       ` dvb usb issues since kernel 4.9 Mauro Carvalho Chehab
2018-01-06 21:07         ` Aw: " Josef Griebichler
2018-01-06 21:44         ` Alan Stern
2018-01-07 11:03           ` Mauro Carvalho Chehab
2018-01-07 15:41             ` Alan Stern
     [not found]               ` <Pine.LNX.4.44L0.1801071010540.13425-100000-pYrvlCTfrz9XsRXLowluHWD2FQJk+8+b@public.gmane.org>
2018-01-07 17:01                 ` Aw: " Josef Griebichler
2018-01-08  9:43               ` Mauro Carvalho Chehab
2018-01-08 16:10                 ` Alan Stern
2018-01-08 16:26                 ` Aw: " Josef Griebichler
2018-01-08 16:31                   ` Alan Stern
2018-01-08 17:15                     ` Aw: " Josef Griebichler
2018-01-08 17:35                       ` Alan Stern
2018-01-08 20:40                         ` Jesper Dangaard Brouer
2018-01-08 21:31                   ` Jesper Dangaard Brouer
2018-01-08 21:44                     ` Peter Zijlstra
2018-01-08 22:16                       ` Jesper Dangaard Brouer
2018-01-09 16:51                         ` Aw: " Josef Griebichler
2018-01-09 17:27                           ` Eric Dumazet
2018-01-09 17:48                             ` Linus Torvalds
2018-01-09 17:57                               ` Eric Dumazet
2018-01-09 18:58                                 ` Linus Torvalds
2018-01-09 21:48                                   ` Eric Dumazet
2018-01-10  9:45                                   ` Jesper Dangaard Brouer
2018-01-12 21:13                               ` Mauro Carvalho Chehab
2018-01-12 21:48                                 ` Eric Dumazet
2018-01-13  9:09                                   ` Mauro Carvalho Chehab
2018-01-13 10:46                                     ` Mauro Carvalho Chehab
2018-01-07 21:23         ` Linus Torvalds
2018-01-08 10:02           ` Mauro Carvalho Chehab
2018-01-08 11:59             ` Jesper Dangaard Brouer
2018-01-08 12:53               ` Mauro Carvalho Chehab
2018-01-08 16:25                 ` Alan Stern
2018-01-08 17:55           ` Ingo Molnar [this message]
2018-01-08 18:32             ` Linus Torvalds
2018-01-08 19:15               ` Alan Stern
2018-01-08 19:51                 ` Linus Torvalds
2018-01-09 17:42                   ` Mauro Carvalho Chehab
2018-01-09 17:55                     ` Linus Torvalds
2018-01-09 21:26                     ` Jesper Dangaard Brouer
2018-01-10  3:02                       ` Mike Galbraith
2018-07-17 11:54                   ` Hanna Hawa
2018-07-17 17:09                     ` Linus Torvalds
2018-07-17 18:07                       ` Hanna Hawa
2018-07-17 22:21                       ` Mauro Carvalho Chehab
2018-01-26 14:17                 ` Mauro Carvalho Chehab
2018-01-26 19:37                   ` Mauro Carvalho Chehab
2018-01-29 13:51                     ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180108175551.wp6thxmiozrz4yp2@gmail.com \
    --to=mingo@kernel.org \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=griebichler.josef@gmx.at \
    --cc=hannes@redhat.com \
    --cc=jbrouer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mchehab@s-opensource.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=stern@rowland.harvard.edu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).