netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: john.fastabend@gmail.com, ast@kernel.org, daniel@iogearbox.net
Cc: netdev@vger.kernel.org
Subject: [bpf-next PATCH 6/7] bpf: sockmap put client sockets in blocking mode
Date: Mon, 08 Jan 2018 10:06:31 -0800	[thread overview]
Message-ID: <20180108180631.13647.7114.stgit@john-Precision-Tower-5810> (raw)
In-Reply-To: <20180108180302.13647.13866.stgit@john-Precision-Tower-5810>

Put client sockets in blocking mode otherwise with sendmsg tests
its easy to overrun the socket buffers which results in the test
being aborted.

The original non-blocking was added to handle listen/accept with
a single thread the client/accepted sockets do not need to be
non-blocking.

Signed-off-by: John Fastabend <john.fastabend@gmail.com>
---
 samples/sockmap/sockmap_user.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/samples/sockmap/sockmap_user.c b/samples/sockmap/sockmap_user.c
index bae85f8..0d8950f 100644
--- a/samples/sockmap/sockmap_user.c
+++ b/samples/sockmap/sockmap_user.c
@@ -110,7 +110,7 @@ static int sockmap_init_sockets(void)
 	}
 
 	/* Non-blocking sockets */
-	for (i = 0; i < 4; i++) {
+	for (i = 0; i < 2; i++) {
 		err = ioctl(*fds[i], FIONBIO, (char *)&one);
 		if (err < 0) {
 			perror("ioctl s1 failed()");

  parent reply	other threads:[~2018-01-08 18:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-08 18:04 [bpf-next PATCH 0/7] sockmap sample updates John Fastabend
2018-01-08 18:05 ` [bpf-next PATCH 1/7] bpf: refactor sockmap sample program update for arg parsing John Fastabend
2018-01-09 13:30   ` Jesper Dangaard Brouer
2018-01-09 16:10     ` John Fastabend
2018-01-08 18:05 ` [bpf-next PATCH 2/7] bpf: add sendmsg option for testing BPF programs John Fastabend
2018-01-08 18:05 ` [bpf-next PATCH 3/7] bpf: sockmap sample, use fork() for send and recv John Fastabend
2018-01-09 23:54   ` Daniel Borkmann
2018-01-08 18:05 ` [bpf-next PATCH 4/7] bpf: sockmap sample, report bytes/sec John Fastabend
2018-01-09 13:27   ` Jesper Dangaard Brouer
2018-01-09 16:16     ` John Fastabend
2018-01-08 18:06 ` [bpf-next PATCH 5/7] bpf: sockmap sample add base test without any BPF for comparison John Fastabend
2018-01-08 18:06 ` John Fastabend [this message]
2018-01-08 18:06 ` [bpf-next PATCH 7/7] bpf: sockmap set rlimit John Fastabend

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180108180631.13647.7114.stgit@john-Precision-Tower-5810 \
    --to=john.fastabend@gmail.com \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).