From: David Miller <davem@davemloft.net>
To: m.xhonneux@gmail.com
Cc: netdev@vger.kernel.org, dlebrun@google.com
Subject: Re: [PATCH net] ipv6: sr: fix TLVs not being copied using setsockopt
Date: Tue, 09 Jan 2018 11:39:43 -0500 (EST) [thread overview]
Message-ID: <20180109.113943.1806562732455657076.davem@davemloft.net> (raw)
In-Reply-To: <CAKSCvkRmX-jHynxPCQSTi4Ppx1y8MKYuoQ4OfPBPgcGhQabN-g@mail.gmail.com>
From: Mathieu Xhonneux <m.xhonneux@gmail.com>
Date: Sun, 7 Jan 2018 16:55:22 +0000
> Just realized I messed up the justification about sr_has_hmac. The
> branch will be taken, but its execution will not complete since the
> TLV's len and type fields aren't copied, hence seg6_get_tlv_hmac will
> fail, and the HMAC will not be computed.
Mathieu, please repost this with the commit message fixed up.
Thank you.
prev parent reply other threads:[~2018-01-09 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-07 17:12 [PATCH net] ipv6: sr: fix TLVs not being copied using setsockopt Mathieu Xhonneux
2018-01-07 16:55 ` Mathieu Xhonneux
2018-01-09 16:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109.113943.1806562732455657076.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dlebrun@google.com \
--cc=m.xhonneux@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).