From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] ipv6: sr: fix TLVs not being copied using setsockopt Date: Tue, 09 Jan 2018 11:39:43 -0500 (EST) Message-ID: <20180109.113943.1806562732455657076.davem@davemloft.net> References: <20180107171204.14443-1-m.xhonneux@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, dlebrun@google.com To: m.xhonneux@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:34006 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754713AbeAIQjp (ORCPT ); Tue, 9 Jan 2018 11:39:45 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Mathieu Xhonneux Date: Sun, 7 Jan 2018 16:55:22 +0000 > Just realized I messed up the justification about sr_has_hmac. The > branch will be taken, but its execution will not complete since the > TLV's len and type fields aren't copied, hence seg6_get_tlv_hmac will > fail, and the HMAC will not be computed. Mathieu, please repost this with the commit message fixed up. Thank you.