From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] net: caif: use strlcpy() instead of strncpy()
Date: Tue, 09 Jan 2018 11:53:21 -0500 (EST)
Message-ID: <20180109.115321.1247410994330927125.davem@davemloft.net>
References: <1515411780-27246-1-git-send-email-wangxiongfeng2@huawei.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, arnd@arndb.de, linux-kernel@vger.kernel.org
To: wangxiongfeng2@huawei.com
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1515411780-27246-1-git-send-email-wangxiongfeng2@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

From: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Date: Mon, 8 Jan 2018 19:43:00 +0800

> From: Xiongfeng Wang <xiongfeng.wang@linaro.org>
> 
> gcc-8 reports
> 
> net/caif/caif_dev.c: In function 'caif_enroll_dev':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' output may
> be truncated copying 15 bytes from a string of length 15
> [-Wstringop-truncation]
> 
> net/caif/cfctrl.c: In function 'cfctrl_linkup_request':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' output may
> be truncated copying 15 bytes from a string of length 15
> [-Wstringop-truncation]
> 
> net/caif/cfcnfg.c: In function 'caif_connect_client':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' output may
> be truncated copying 15 bytes from a string of length 15
> [-Wstringop-truncation]
> 
> The compiler require that the input param 'len' of strncpy() should be
> greater than the length of the src string, so that '\0' is copied as
> well. We can just use strlcpy() to avoid this warning.
> 
> Signed-off-by: Xiongfeng Wang <xiongfeng.wang@linaro.org>

Applied, thank you.