From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 0/3] ethtool ringparam upper bound Date: Tue, 09 Jan 2018 11:55:08 -0500 (EST) Message-ID: <20180109.115508.2272049544268725175.davem@davemloft.net> References: <1515420026-11970-1-git-send-email-tariqt@mellanox.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, eranbe@mellanox.com, eugenia@mellanox.com To: tariqt@mellanox.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:34336 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751259AbeAIQzK (ORCPT ); Tue, 9 Jan 2018 11:55:10 -0500 In-Reply-To: <1515420026-11970-1-git-send-email-tariqt@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Tariq Toukan Date: Mon, 8 Jan 2018 16:00:23 +0200 > This patchset by Jenny adds sanity checks in ethtool ringparam > operation for input upper bounds, similarly to what's done in > ethtool_set_channels. > > The checks are added in patch 1, using a call to get_ringparam > prior to calling set_ringparam NDO. > > Patch 2 changes the function's behavior in mlx4_en, so that > it returns an error for out-of-range input, instead of rounding > it to closest valid, similar to mlx5e. > > Patch 3 removes the upper bound checks in mlx5e_ethtool_set_ringparam > as it becomes redundant. > > Series generated against net-next commit: > f66faae2f80a Merge branch 'ipv6-ipv4-nexthop-align' Series applied, thank you.