From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ido Schimmel <idosch@idosch.org>
Subject: Re: [PATCH net-next 00/18] ipv6: Align nexthop behaviour with IPv4
Date: Tue, 9 Jan 2018 10:04:24 +0200
Message-ID: <20180109080424.GA6699@splinter>
References: <20180107104518.31693-1-idosch@mellanox.com>
 <5c10b955-161d-9cb1-edd1-7a49d88e46ad@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Ido Schimmel <idosch@mellanox.com>, netdev@vger.kernel.org,
        davem@davemloft.net, roopa@cumulusnetworks.com,
        nicolas.dichtel@6wind.com, weiwan@google.com, kafai@fb.com,
        yoshfuji@linux-ipv6.org, mlxsw@mellanox.com
To: David Ahern <dsahern@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:35001 "EHLO
        out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1753266AbeAIIEa (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 9 Jan 2018 03:04:30 -0500
Content-Disposition: inline
In-Reply-To: <5c10b955-161d-9cb1-edd1-7a49d88e46ad@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Sun, Jan 07, 2018 at 10:20:11AM -0700, David Ahern wrote:
> One of many follow on changes that would be beneficial is to remove the
> idev dereference in the hot path to check the
> ignore_routes_with_linkdown sysctl.

When a netdev loses its carrier we can set the RTNH_F_DEAD flag for all
the nexthops using it as their nexthop device, in case the sysctl is
set. Similarly, when the sysctl is toggled we can walk the routing
tables and toggle the flag where appropriate.

You have a different idea?

Thanks for reviewing!