From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
davem@davemloft.net, kishon@ti.com, andrew@lunn.ch,
gregory.clement@free-electrons.com, mw@semihalf.com,
stefanc@marvell.com, ymarkman@marvell.com,
thomas.petazzoni@free-electrons.com,
miquel.raynal@free-electrons.com, nadavh@marvell.com,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 4/4] net: mvpp2: 2500baseX support
Date: Tue, 9 Jan 2018 16:11:50 +0100 [thread overview]
Message-ID: <20180109151150.GA23676@kwain> (raw)
In-Reply-To: <20180109144238.GH17719@n2100.armlinux.org.uk>
Hi Russell,
On Tue, Jan 09, 2018 at 02:42:38PM +0000, Russell King - ARM Linux wrote:
> On Tue, Jan 09, 2018 at 09:59:45AM +0100, Antoine Tenart wrote:
> > This patch adds the 2500Base-X PHY mode support in the Marvell PPv2
> > driver. 2500Base-X is quite close to 1000Base-X and SGMII modes and uses
> > nearly the same code path.
>
> For 2500Base-X, do you report a speed of 2500Mbps through ethtool, or
> are you reporting 1000Mbps? I don't see any code in this patch that
> deals with that.
The mvpp2 driver uses phy_ethtool_get_link_ksettings() to report the
link speed to Ethtool. So it's reporting the speed set by the PHY
driver.
So it'll be something to ensure when adding PHYs supporting the mode.
We'll have the opportunity to see this when adding the last mcbin
interface.
Thanks!
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2018-01-09 15:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 8:59 [PATCH net-next v3 0/4] net: mvpp2: 1000BaseX and 2500BaseX support Antoine Tenart
2018-01-09 8:59 ` [PATCH net-next v3 1/4] phy: add 2.5G SGMII mode to the phy_mode enum Antoine Tenart
2018-01-09 8:59 ` [PATCH net-next v3 2/4] phy: cp110-comphy: 2.5G SGMII mode Antoine Tenart
2018-01-09 8:59 ` [PATCH net-next v3 3/4] net: mvpp2: 1000baseX support Antoine Tenart
2018-01-09 8:59 ` [PATCH net-next v3 4/4] net: mvpp2: 2500baseX support Antoine Tenart
2018-01-09 14:13 ` Andrew Lunn
2018-01-09 14:42 ` Russell King - ARM Linux
2018-01-09 15:11 ` Antoine Tenart [this message]
2018-01-09 14:44 ` Russell King - ARM Linux
2018-01-09 15:17 ` Antoine Tenart
2018-01-09 15:54 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109151150.GA23676@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=miquel.raynal@free-electrons.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=ymarkman@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).