* [PATCH][next] rtlwifi: btcoexist: remove redundant variable fw_ps_state
@ 2018-01-09 16:43 Colin King
2018-01-09 16:48 ` Larry Finger
2018-01-16 15:59 ` [next] " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2018-01-09 16:43 UTC (permalink / raw)
To: Ping-Ke Shih, Kalle Valo, Larry Finger, Yan-Hsuan Chuang,
linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable fw_ps_state is assigned a value but it is never read, hence
it is redundant and can be removed.
Cleans up clang warning:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:736:2:
warning: Value stored to 'fw_ps_state' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
index 5f3eda31187a..873bf9303d5d 100644
--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
@@ -677,7 +677,7 @@ static void halbtc_display_wifi_status(struct btc_coexist *btcoexist,
u32 wifi_link_status = 0x0;
bool bt_hs_on = false, under_ips = false, under_lps = false;
bool low_power = false, dc_mode = false;
- u8 wifi_chnl = 0, wifi_hs_chnl = 0, fw_ps_state;
+ u8 wifi_chnl = 0, wifi_hs_chnl = 0;
u8 ap_num = 0;
wifi_link_status = halbtc_get_wifi_link_status(btcoexist);
@@ -733,7 +733,6 @@ static void halbtc_display_wifi_status(struct btc_coexist *btcoexist,
dc_mode = true; /*TODO*/
under_ips = rtlpriv->psc.inactive_pwrstate == ERFOFF ? 1 : 0;
under_lps = rtlpriv->psc.dot11_psmode == EACTIVE ? 0 : 1;
- fw_ps_state = 0;
low_power = 0; /*TODO*/
seq_printf(m, "\n %-35s = %s%s%s%s",
"Power Status",
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] rtlwifi: btcoexist: remove redundant variable fw_ps_state
2018-01-09 16:43 [PATCH][next] rtlwifi: btcoexist: remove redundant variable fw_ps_state Colin King
@ 2018-01-09 16:48 ` Larry Finger
2018-01-16 15:59 ` [next] " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Larry Finger @ 2018-01-09 16:48 UTC (permalink / raw)
To: Colin King, Ping-Ke Shih, Kalle Valo, Yan-Hsuan Chuang,
linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
On 01/09/2018 10:43 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable fw_ps_state is assigned a value but it is never read, hence
> it is redundant and can be removed.
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
>
> Cleans up clang warning:
> drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:736:2:
> warning: Value stored to 'fw_ps_state' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> index 5f3eda31187a..873bf9303d5d 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> @@ -677,7 +677,7 @@ static void halbtc_display_wifi_status(struct btc_coexist *btcoexist,
> u32 wifi_link_status = 0x0;
> bool bt_hs_on = false, under_ips = false, under_lps = false;
> bool low_power = false, dc_mode = false;
> - u8 wifi_chnl = 0, wifi_hs_chnl = 0, fw_ps_state;
> + u8 wifi_chnl = 0, wifi_hs_chnl = 0;
> u8 ap_num = 0;
>
> wifi_link_status = halbtc_get_wifi_link_status(btcoexist);
> @@ -733,7 +733,6 @@ static void halbtc_display_wifi_status(struct btc_coexist *btcoexist,
> dc_mode = true; /*TODO*/
> under_ips = rtlpriv->psc.inactive_pwrstate == ERFOFF ? 1 : 0;
> under_lps = rtlpriv->psc.dot11_psmode == EACTIVE ? 0 : 1;
> - fw_ps_state = 0;
> low_power = 0; /*TODO*/
> seq_printf(m, "\n %-35s = %s%s%s%s",
> "Power Status",
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [next] rtlwifi: btcoexist: remove redundant variable fw_ps_state
2018-01-09 16:43 [PATCH][next] rtlwifi: btcoexist: remove redundant variable fw_ps_state Colin King
2018-01-09 16:48 ` Larry Finger
@ 2018-01-16 15:59 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2018-01-16 15:59 UTC (permalink / raw)
To: Colin Ian King
Cc: Ping-Ke Shih, Larry Finger, Yan-Hsuan Chuang, linux-wireless,
netdev, kernel-janitors, linux-kernel
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable fw_ps_state is assigned a value but it is never read, hence
> it is redundant and can be removed.
>
> Cleans up clang warning:
> drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:736:2:
> warning: Value stored to 'fw_ps_state' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Patch applied to wireless-drivers-next.git, thanks.
7e2c49222b4e rtlwifi: btcoexist: remove redundant variable fw_ps_state
--
https://patchwork.kernel.org/patch/10152901/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-16 15:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-09 16:43 [PATCH][next] rtlwifi: btcoexist: remove redundant variable fw_ps_state Colin King
2018-01-09 16:48 ` Larry Finger
2018-01-16 15:59 ` [next] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).