netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Paul Greenwalt <paul.greenwalt@intel.com>,
	netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
	jogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 03/13] ixgbe: advertise highest capable link speed
Date: Tue,  9 Jan 2018 11:02:23 -0800	[thread overview]
Message-ID: <20180109190233.15206-4-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20180109190233.15206-1-jeffrey.t.kirsher@intel.com>

From: Paul Greenwalt <paul.greenwalt@intel.com>

On module insert advertise highest capable link speed. If module is
capable of 10G, then advertise 10G, else advertise modules capable
link speeds.

Signed-off-by: Paul Greenwalt <paul.greenwalt@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 43ca5b0d5999..07d929bf4b50 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -7656,6 +7656,7 @@ static void ixgbe_sfp_detection_subtask(struct ixgbe_adapter *adapter)
 static void ixgbe_sfp_link_config_subtask(struct ixgbe_adapter *adapter)
 {
 	struct ixgbe_hw *hw = &adapter->hw;
+	u32 cap_speed;
 	u32 speed;
 	bool autoneg = false;
 
@@ -7668,16 +7669,14 @@ static void ixgbe_sfp_link_config_subtask(struct ixgbe_adapter *adapter)
 
 	adapter->flags &= ~IXGBE_FLAG_NEED_LINK_CONFIG;
 
-	speed = hw->phy.autoneg_advertised;
-	if ((!speed) && (hw->mac.ops.get_link_capabilities)) {
-		hw->mac.ops.get_link_capabilities(hw, &speed, &autoneg);
+	hw->mac.ops.get_link_capabilities(hw, &cap_speed, &autoneg);
 
-		/* setup the highest link when no autoneg */
-		if (!autoneg) {
-			if (speed & IXGBE_LINK_SPEED_10GB_FULL)
-				speed = IXGBE_LINK_SPEED_10GB_FULL;
-		}
-	}
+	/* advertise highest capable link speed */
+	if (!autoneg && (cap_speed & IXGBE_LINK_SPEED_10GB_FULL))
+		speed = IXGBE_LINK_SPEED_10GB_FULL;
+	else
+		speed = cap_speed & (IXGBE_LINK_SPEED_10GB_FULL |
+				     IXGBE_LINK_SPEED_1GB_FULL);
 
 	if (hw->mac.ops.setup_link)
 		hw->mac.ops.setup_link(hw, speed, true);
-- 
2.15.1

  parent reply	other threads:[~2018-01-09 19:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09 19:02 [net-next 00/13][pull request] 10GbE Intel Wired LAN Driver Updates 2018-01-09 Jeff Kirsher
2018-01-09 19:02 ` [net-next 01/13] ixgbe: enable multicast on shutdown for WOL Jeff Kirsher
2018-01-09 19:02 ` [net-next 02/13] ixgbe: remove unused enum latency_range Jeff Kirsher
2018-01-09 19:02 ` Jeff Kirsher [this message]
2018-01-09 19:02 ` [net-next 04/13] ixgbe: extend firmware version support Jeff Kirsher
2018-01-09 19:02 ` [net-next 05/13] ixgbe: Remove an obsolete comment about ITR Jeff Kirsher
2018-01-09 19:02 ` [net-next 06/13] ixgbevf: remove redundant setting of xcast_mode Jeff Kirsher
2018-01-09 19:02 ` [net-next 07/13] ixgbe: Fix interaction between SR-IOV and macvlan offload Jeff Kirsher
2018-01-09 19:02 ` [net-next 08/13] ixgbe: Perform reinit any time number of VFs change Jeff Kirsher
2018-01-09 19:02 ` [net-next 09/13] ixgbe: Add support for macvlan offload RSS on X550 and clean-up pool handling Jeff Kirsher
2018-01-09 19:02 ` [net-next 10/13] ixgbe: There is no need to update num_rx_pools in L2 fwd offload Jeff Kirsher
2018-01-09 19:02 ` [net-next 11/13] ixgbe: Fix limitations on macvlan so we can support up to 63 offloaded devices Jeff Kirsher
2018-01-09 19:02 ` [net-next 12/13] ixgbe: Use ring values to test for Tx pending Jeff Kirsher
2018-01-09 19:02 ` [net-next 13/13] ixgbe: Drop l2_accel_priv data pointer from ring struct Jeff Kirsher
2018-01-10 19:45 ` [net-next 00/13][pull request] 10GbE Intel Wired LAN Driver Updates 2018-01-09 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180109190233.15206-4-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=jogreene@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=paul.greenwalt@intel.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).