From: kbuild test robot <lkp@intel.com>
To: Andy Gospodarek <andy@greyhouse.net>
Cc: kbuild-all@01.org, netdev@vger.kernel.org, mchan@broadcom.com,
talgi@mellanox.com, ogerlitz@mellanox.com,
Andy Gospodarek <gospo@broadcom.com>
Subject: Re: [PATCH net-next v3 06/10] net/mlx5e: Change Mellanox references in DIM code
Date: Tue, 9 Jan 2018 20:08:18 +0800 [thread overview]
Message-ID: <201801091908.EXxJ4Dwg%fengguang.wu@intel.com> (raw)
In-Reply-To: <1515478402-6048-7-git-send-email-andy@greyhouse.net>
Hi Andy,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Andy-Gospodarek/net-create-dynamic-software-irq-moderation-library/20180109-182838
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:887:15: sparse: no member 'rx_am_enabled' in struct mlx5e_params
>> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:887:33: sparse: call with no type!
>> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:887:33: sparse: call with no type!
>> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:887:33: sparse: unknown expression (14 0)
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:887:33: sparse: unknown expression (30 46)
>> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:887:33: sparse: unknown expression (14 0)
>> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:887:15: sparse: generating address of non-lvalue (8)
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function 'mlx5e_build_rep_params':
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:887:10: error: 'struct mlx5e_params' has no member named 'rx_am_enabled'; did you mean
params->rx_am_enabled = MLX5_CAP_GEN(mdev, cq_moderation);
^~~~~~~~~~~~~
rx_dim_enabled
vim +887 drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
cb67b832 Hadar Hen Zion 2016-07-01 875
6a9764ef Saeed Mahameed 2016-12-21 876 static void mlx5e_build_rep_params(struct mlx5_core_dev *mdev,
6a9764ef Saeed Mahameed 2016-12-21 877 struct mlx5e_params *params)
cb67b832 Hadar Hen Zion 2016-07-01 878 {
cb67b832 Hadar Hen Zion 2016-07-01 879 u8 cq_period_mode = MLX5_CAP_GEN(mdev, cq_period_start_from_cqe) ?
cb67b832 Hadar Hen Zion 2016-07-01 880 MLX5_CQ_PERIOD_MODE_START_FROM_CQE :
cb67b832 Hadar Hen Zion 2016-07-01 881 MLX5_CQ_PERIOD_MODE_START_FROM_EQE;
cb67b832 Hadar Hen Zion 2016-07-01 882
6a9764ef Saeed Mahameed 2016-12-21 883 params->log_sq_size = MLX5E_PARAMS_MINIMUM_LOG_SQ_SIZE;
6a9764ef Saeed Mahameed 2016-12-21 884 params->rq_wq_type = MLX5_WQ_TYPE_LINKED_LIST;
6a9764ef Saeed Mahameed 2016-12-21 885 params->log_rq_size = MLX5E_PARAMS_MINIMUM_LOG_RQ_SIZE;
cb67b832 Hadar Hen Zion 2016-07-01 886
6a9764ef Saeed Mahameed 2016-12-21 @887 params->rx_am_enabled = MLX5_CAP_GEN(mdev, cq_moderation);
6a9764ef Saeed Mahameed 2016-12-21 888 mlx5e_set_rx_cq_mode_params(params, cq_period_mode);
cb67b832 Hadar Hen Zion 2016-07-01 889
6a9764ef Saeed Mahameed 2016-12-21 890 params->tx_max_inline = mlx5e_get_max_inline_cap(mdev);
6a9764ef Saeed Mahameed 2016-12-21 891 params->num_tc = 1;
6a9764ef Saeed Mahameed 2016-12-21 892 params->lro_wqe_sz = MLX5E_PARAMS_DEFAULT_LRO_WQE_SZ;
5f195c2c Chris Mi 2017-05-16 893
5f195c2c Chris Mi 2017-05-16 894 mlx5_query_min_inline(mdev, ¶ms->tx_min_inline_mode);
cb67b832 Hadar Hen Zion 2016-07-01 895 }
cb67b832 Hadar Hen Zion 2016-07-01 896
:::::: The code at line 887 was first introduced by commit
:::::: 6a9764efb255f49a91e229799c38d5c1c9361987 net/mlx5e: Isolate open_channels from priv->params
:::::: TO: Saeed Mahameed <saeedm@mellanox.com>
:::::: CC: Saeed Mahameed <saeedm@mellanox.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2018-01-09 12:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 6:13 [PATCH net-next v3 00/10] net: create dynamic software irq moderation library Andy Gospodarek
2018-01-09 6:13 ` [PATCH net-next v3 01/10] net/mlx5e: Move interrupt moderation structs to new file Andy Gospodarek
2018-01-09 6:13 ` [PATCH net-next v3 02/10] net/mlx5e: Move interrupt moderation forward declarations Andy Gospodarek
2018-01-09 6:13 ` [PATCH net-next v3 03/10] net/mlx5e: Remove rq references in mlx5e_rx_am Andy Gospodarek
2018-01-09 6:13 ` [PATCH net-next v3 04/10] net/mlx5e: Move AM logic enums Andy Gospodarek
2018-01-09 6:13 ` [PATCH net-next v3 05/10] net/mlx5e: Move generic functions to new file Andy Gospodarek
2018-01-09 6:13 ` [PATCH net-next v3 06/10] net/mlx5e: Change Mellanox references in DIM code Andy Gospodarek
2018-01-09 7:06 ` Saeed Mahameed
2018-01-09 7:09 ` Saeed Mahameed
2018-01-09 16:06 ` Andy Gospodarek
2018-01-09 18:22 ` Tal Gilboa
2018-01-09 19:38 ` Andy Gospodarek
2018-01-09 11:12 ` kbuild test robot
2018-01-09 12:08 ` kbuild test robot [this message]
2018-01-09 6:13 ` [PATCH net-next v3 07/10] net/mlx5e: Move dynamic interrupt coalescing code to include/linux Andy Gospodarek
2018-01-09 6:13 ` [PATCH net-next v3 08/10] net/dim: use struct net_dim_sample as arg to net_dim Andy Gospodarek
2018-01-09 6:13 ` [PATCH net-next v3 09/10] bnxt_en: add support for software dynamic interrupt moderation Andy Gospodarek
2018-01-09 7:07 ` Michael Chan
2018-01-09 6:13 ` [PATCH net-next v3 10/10] MAINTAINERS: add entry for Dynamic Interrupt Moderation Andy Gospodarek
2018-01-09 6:54 ` [PATCH net-next v3 00/10] net: create dynamic software irq moderation library Tal Gilboa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201801091908.EXxJ4Dwg%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=andy@greyhouse.net \
--cc=gospo@broadcom.com \
--cc=kbuild-all@01.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=talgi@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).