* [PATCH] doc: clarification about setting SO_ZEROCOPY
@ 2018-01-09 8:52 Kornilios Kourtis
2018-01-09 13:05 ` Willem de Bruijn
2018-01-10 20:02 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Kornilios Kourtis @ 2018-01-09 8:52 UTC (permalink / raw)
To: netdev; +Cc: Willem de Bruijn
Signed-off-by: Kornilios Kourtis <kou@zurich.ibm.com>
---
Documentation/networking/msg_zerocopy.rst | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/networking/msg_zerocopy.rst b/Documentation/networking/msg_zerocopy.rst
index 77f6d7e..c3380f4 100644
--- a/Documentation/networking/msg_zerocopy.rst
+++ b/Documentation/networking/msg_zerocopy.rst
@@ -72,6 +72,10 @@ this flag, a process must first signal intent by setting a socket option:
if (setsockopt(fd, SOL_SOCKET, SO_ZEROCOPY, &one, sizeof(one)))
error(1, errno, "setsockopt zerocopy");
+Setting the socket option only works when the socket is in its initial
+(TCP_CLOSED) state. Trying to set the option for a socket returned by accept(),
+for example, will lead to an EBUSY error. In this case, the option should be set
+to the listening socket and it will be inherited by the accepted sockets.
Transmission
------------
--
2.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] doc: clarification about setting SO_ZEROCOPY
2018-01-09 8:52 [PATCH] doc: clarification about setting SO_ZEROCOPY Kornilios Kourtis
@ 2018-01-09 13:05 ` Willem de Bruijn
2018-01-10 20:02 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Willem de Bruijn @ 2018-01-09 13:05 UTC (permalink / raw)
To: Kornilios Kourtis; +Cc: Network Development, Willem de Bruijn
On Tue, Jan 9, 2018 at 3:52 AM, Kornilios Kourtis <kou@zurich.ibm.com> wrote:
> Signed-off-by: Kornilios Kourtis <kou@zurich.ibm.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Thanks, Kornilios.
> ---
> Documentation/networking/msg_zerocopy.rst | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/networking/msg_zerocopy.rst b/Documentation/networking/msg_zerocopy.rst
> index 77f6d7e..c3380f4 100644
> --- a/Documentation/networking/msg_zerocopy.rst
> +++ b/Documentation/networking/msg_zerocopy.rst
> @@ -72,6 +72,10 @@ this flag, a process must first signal intent by setting a socket option:
> if (setsockopt(fd, SOL_SOCKET, SO_ZEROCOPY, &one, sizeof(one)))
> error(1, errno, "setsockopt zerocopy");
>
> +Setting the socket option only works when the socket is in its initial
> +(TCP_CLOSED) state. Trying to set the option for a socket returned by accept(),
> +for example, will lead to an EBUSY error. In this case, the option should be set
> +to the listening socket and it will be inherited by the accepted sockets.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] doc: clarification about setting SO_ZEROCOPY
2018-01-09 8:52 [PATCH] doc: clarification about setting SO_ZEROCOPY Kornilios Kourtis
2018-01-09 13:05 ` Willem de Bruijn
@ 2018-01-10 20:02 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-01-10 20:02 UTC (permalink / raw)
To: kou; +Cc: netdev, willemb
From: Kornilios Kourtis <kou@zurich.ibm.com>
Date: Tue, 9 Jan 2018 09:52:22 +0100
> Signed-off-by: Kornilios Kourtis <kou@zurich.ibm.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-10 20:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-09 8:52 [PATCH] doc: clarification about setting SO_ZEROCOPY Kornilios Kourtis
2018-01-09 13:05 ` Willem de Bruijn
2018-01-10 20:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).