From: David Miller <davem@davemloft.net>
To: wangxiongfeng2@huawei.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] caif_usb: use strlcpy() instead of strncpy()
Date: Wed, 10 Jan 2018 15:06:27 -0500 (EST) [thread overview]
Message-ID: <20180110.150627.1824860958372498944.davem@davemloft.net> (raw)
In-Reply-To: <1515499098-159956-1-git-send-email-wangxiongfeng2@huawei.com>
From: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Date: Tue, 9 Jan 2018 19:58:18 +0800
> From: Xiongfeng Wang <xiongfeng.wang@linaro.org>
>
> gcc-8 reports
>
> net/caif/caif_usb.c: In function 'cfusbl_device_notify':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' output may
> be truncated copying 15 bytes from a string of length 15
> [-Wstringop-truncation]
>
> The compiler require that the input param 'len' of strncpy() should be
> greater than the length of the src string, so that '\0' is copied as
> well. We can just use strlcpy() to avoid this warning.
>
> Signed-off-by: Xiongfeng Wang <xiongfeng.wang@linaro.org>
Applied.
prev parent reply other threads:[~2018-01-10 20:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 11:58 [PATCH] caif_usb: use strlcpy() instead of strncpy() Xiongfeng Wang
2018-01-10 20:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110.150627.1824860958372498944.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wangxiongfeng2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).