From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] caif_usb: use strlcpy() instead of strncpy() Date: Wed, 10 Jan 2018 15:06:27 -0500 (EST) Message-ID: <20180110.150627.1824860958372498944.davem@davemloft.net> References: <1515499098-159956-1-git-send-email-wangxiongfeng2@huawei.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: wangxiongfeng2@huawei.com Return-path: In-Reply-To: <1515499098-159956-1-git-send-email-wangxiongfeng2@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Xiongfeng Wang Date: Tue, 9 Jan 2018 19:58:18 +0800 > From: Xiongfeng Wang > > gcc-8 reports > > net/caif/caif_usb.c: In function 'cfusbl_device_notify': > ./include/linux/string.h:245:9: warning: '__builtin_strncpy' output may > be truncated copying 15 bytes from a string of length 15 > [-Wstringop-truncation] > > The compiler require that the input param 'len' of strncpy() should be > greater than the length of the src string, so that '\0' is copied as > well. We can just use strlcpy() to avoid this warning. > > Signed-off-by: Xiongfeng Wang Applied.