From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: netdev@vger.kernel.org, dvyukov@google.com, vyasevich@gmail.com,
ben.hutchings@codethink.co.uk
Subject: Re: [Patch net] 8021q: fix a memory leak for VLAN 0 device
Date: Wed, 10 Jan 2018 15:31:27 -0500 (EST) [thread overview]
Message-ID: <20180110.153127.366385711220396218.davem@davemloft.net> (raw)
In-Reply-To: <20180109214041.26842-1-xiyou.wangcong@gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Tue, 9 Jan 2018 13:40:41 -0800
> A vlan device with vid 0 is allow to creat by not able to be fully
> cleaned up by unregister_vlan_dev() which checks for vlan_id!=0.
>
> Also, VLAN 0 is probably not a valid number and it is kinda
> "reserved" for HW accelerating devices, but it is probably too
> late to reject it from creation even if makes sense. Instead,
> just remove the check in unregister_vlan_dev().
>
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Fixes: ad1afb003939 ("vlan_dev: VLAN 0 should be treated as "no vlan tag" (802.1p packet)")
> Cc: Vlad Yasevich <vyasevich@gmail.com>
> Cc: Ben Hutchings <ben.hutchings@codethink.co.uk>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2018-01-10 20:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 21:40 [Patch net] 8021q: fix a memory leak for VLAN 0 device Cong Wang
2018-01-09 22:30 ` Nikolay Aleksandrov
2018-01-09 22:47 ` Cong Wang
2018-01-09 22:53 ` Nikolay Aleksandrov
2018-01-09 23:06 ` Cong Wang
2018-01-09 23:13 ` Nikolay Aleksandrov
2018-01-10 20:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110.153127.366385711220396218.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben.hutchings@codethink.co.uk \
--cc=dvyukov@google.com \
--cc=netdev@vger.kernel.org \
--cc=vyasevich@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).