From: David Miller <davem@davemloft.net>
To: linus.walleij@linaro.org
Cc: netdev@vger.kernel.org, mirq-linux@rere.qmqm.pl,
janos.dev@gmail.com, paulius.zaleckas@gmail.com,
linux-arm-kernel@lists.infradead.org, ulli.kroll@googlemail.com,
f.fainelli@gmail.com, tobias.waldvogel@gmail.com
Subject: Re: [PATCH net-next 2/2 v10] net: ethernet: Add a driver for Gemini gigabit ethernet
Date: Wed, 10 Jan 2018 15:43:22 -0500 (EST) [thread overview]
Message-ID: <20180110.154322.2235369645563224203.davem@davemloft.net> (raw)
In-Reply-To: <20180110.154113.1759667248487481665.davem@davemloft.net>
Actually I had to revert these two patches, this stuff doesn't even
build.
[davem@dhcp-10-15-49-227 net-next]$ make -s -j16
In file included from ./include/linux/printk.h:329:0,
from ./include/linux/kernel.h:14,
from ./include/linux/list.h:9,
from ./include/linux/module.h:9,
from drivers/net/ethernet/cortina/gemini.c:16:
drivers/net/ethernet/cortina/gemini.c: In function ‘geth_freeq_alloc_map_page’:
drivers/net/ethernet/cortina/gemini.c:821:21: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘dma_addr_t {aka long long unsigned int}’ [-Wformat=]
dev_dbg(geth->dev, "page %d, DMA addr: %08x, page %p\n",
^
./include/linux/dynamic_debug.h:135:39: note: in definition of macro ‘dynamic_dev_dbg’
__dynamic_dev_dbg(&descriptor, dev, fmt, \
^~~
drivers/net/ethernet/cortina/gemini.c:821:2: note: in expansion of macro ‘dev_dbg’
dev_dbg(geth->dev, "page %d, DMA addr: %08x, page %p\n",
^~~~~~~
drivers/net/ethernet/cortina/gemini.c: In function ‘gmac_rx’:
drivers/net/ethernet/cortina/gemini.c:1410:50: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘dma_addr_t {aka long long unsigned int}’ [-Wformat=]
dev_err(geth->dev, "could not find mapping %08x (page = %08x, page off = %08x)\n",
~~~^
%08llx
drivers/net/ethernet/cortina/gemini.c:1410:63: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘long long unsigned int’ [-Wformat=]
dev_err(geth->dev, "could not find mapping %08x (page = %08x, page off = %08x)\n",
~~~^
%08llx
drivers/net/ethernet/cortina/gemini.c: In function ‘gemini_ethernet_port_probe’:
drivers/net/ethernet/cortina/gemini.c:2456:28: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘resource_size_t {aka long long unsigned int}’ [-Wformat=]
"irq %d, DMA @ 0x%08x, GMAC @ 0x%08x\n",
~~~^
%08llx
port->irq, dmares->start,
~~~~~~~~~~~~~
drivers/net/ethernet/cortina/gemini.c:2456:43: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘resource_size_t {aka long long unsigned int}’ [-Wformat=]
"irq %d, DMA @ 0x%08x, GMAC @ 0x%08x\n",
~~~^
%08llx
drivers/net/ethernet/cortina/gemini.c:2458:8:
gmacres->start);
~~~~~~~~~~~~~~
In file included from drivers/net/ethernet/cortina/gemini.c:16:0:
drivers/net/ethernet/cortina/gemini.c: At top level:
./include/linux/module.h:129:42: error: redefinition of ‘__inittest’
static inline initcall_t __maybe_unused __inittest(void) \
^
./include/linux/device.h:1513:1: note: in expansion of macro ‘module_init’
module_init(__driver##_init); \
^~~~~~~~~~~
./include/linux/platform_device.h:228:2: note: in expansion of macro ‘module_driver’
module_driver(__platform_driver, platform_driver_register, \
^~~~~~~~~~~~~
drivers/net/ethernet/cortina/gemini.c:2567:1: note: in expansion of macro ‘module_platform_driver’
module_platform_driver(gemini_ethernet_driver);
^~~~~~~~~~~~~~~~~~~~~~
./include/linux/module.h:129:42: note: previous definition of ‘__inittest’ was here
static inline initcall_t __maybe_unused __inittest(void) \
^
./include/linux/device.h:1513:1: note: in expansion of macro ‘module_init’
module_init(__driver##_init); \
^~~~~~~~~~~
./include/linux/platform_device.h:228:2: note: in expansion of macro ‘module_driver’
module_driver(__platform_driver, platform_driver_register, \
^~~~~~~~~~~~~
drivers/net/ethernet/cortina/gemini.c:2495:1: note: in expansion of macro ‘module_platform_driver’
module_platform_driver(gemini_ethernet_port_driver);
^~~~~~~~~~~~~~~~~~~~~~
./include/linux/module.h:131:6: error: redefinition of ‘init_module’
int init_module(void) __attribute__((alias(#initfn)));
^
./include/linux/device.h:1513:1: note: in expansion of macro ‘module_init’
module_init(__driver##_init); \
^~~~~~~~~~~
./include/linux/platform_device.h:228:2: note: in expansion of macro ‘module_driver’
module_driver(__platform_driver, platform_driver_register, \
^~~~~~~~~~~~~
drivers/net/ethernet/cortina/gemini.c:2567:1: note: in expansion of macro ‘module_platform_driver’
module_platform_driver(gemini_ethernet_driver);
^~~~~~~~~~~~~~~~~~~~~~
./include/linux/module.h:131:6: note: previous definition of ‘init_module’ was here
int init_module(void) __attribute__((alias(#initfn)));
^
./include/linux/device.h:1513:1: note: in expansion of macro ‘module_init’
module_init(__driver##_init); \
^~~~~~~~~~~
./include/linux/platform_device.h:228:2: note: in expansion of macro ‘module_driver’
module_driver(__platform_driver, platform_driver_register, \
^~~~~~~~~~~~~
drivers/net/ethernet/cortina/gemini.c:2495:1: note: in expansion of macro ‘module_platform_driver’
module_platform_driver(gemini_ethernet_port_driver);
^~~~~~~~~~~~~~~~~~~~~~
./include/linux/module.h:135:42: error: redefinition of ‘__exittest’
static inline exitcall_t __maybe_unused __exittest(void) \
^
./include/linux/device.h:1518:1: note: in expansion of macro ‘module_exit’
module_exit(__driver##_exit);
^~~~~~~~~~~
./include/linux/platform_device.h:228:2: note: in expansion of macro ‘module_driver’
module_driver(__platform_driver, platform_driver_register, \
^~~~~~~~~~~~~
drivers/net/ethernet/cortina/gemini.c:2567:1: note: in expansion of macro ‘module_platform_driver’
module_platform_driver(gemini_ethernet_driver);
^~~~~~~~~~~~~~~~~~~~~~
./include/linux/module.h:135:42: note: previous definition of ‘__exittest’ was here
static inline exitcall_t __maybe_unused __exittest(void) \
^
./include/linux/device.h:1518:1: note: in expansion of macro ‘module_exit’
module_exit(__driver##_exit);
^~~~~~~~~~~
./include/linux/platform_device.h:228:2: note: in expansion of macro ‘module_driver’
module_driver(__platform_driver, platform_driver_register, \
^~~~~~~~~~~~~
drivers/net/ethernet/cortina/gemini.c:2495:1: note: in expansion of macro ‘module_platform_driver’
module_platform_driver(gemini_ethernet_port_driver);
^~~~~~~~~~~~~~~~~~~~~~
./include/linux/module.h:137:7: error: redefinition of ‘cleanup_module’
void cleanup_module(void) __attribute__((alias(#exitfn)));
^
./include/linux/device.h:1518:1: note: in expansion of macro ‘module_exit’
module_exit(__driver##_exit);
^~~~~~~~~~~
./include/linux/platform_device.h:228:2: note: in expansion of macro ‘module_driver’
module_driver(__platform_driver, platform_driver_register, \
^~~~~~~~~~~~~
drivers/net/ethernet/cortina/gemini.c:2567:1: note: in expansion of macro ‘module_platform_driver’
module_platform_driver(gemini_ethernet_driver);
^~~~~~~~~~~~~~~~~~~~~~
./include/linux/module.h:137:7: note: previous definition of ‘cleanup_module’ was here
void cleanup_module(void) __attribute__((alias(#exitfn)));
^
./include/linux/device.h:1518:1: note: in expansion of macro ‘module_exit’
module_exit(__driver##_exit);
^~~~~~~~~~~
./include/linux/platform_device.h:228:2: note: in expansion of macro ‘module_driver’
module_driver(__platform_driver, platform_driver_register, \
^~~~~~~~~~~~~
drivers/net/ethernet/cortina/gemini.c:2495:1: note: in expansion of macro ‘module_platform_driver’
module_platform_driver(gemini_ethernet_port_driver);
^~~~~~~~~~~~~~~~~~~~~~
make[4]: *** [scripts/Makefile.build:317: drivers/net/ethernet/cortina/gemini.o] Error 1
make[3]: *** [scripts/Makefile.build:569: drivers/net/ethernet/cortina] Error 2
make[3]: *** Waiting for unfinished jobs....
next prev parent reply other threads:[~2018-01-10 20:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 22:10 [PATCH net-next 1/2 v10] net: ethernet: Add DT bindings for the Gemini ethernet Linus Walleij
2018-01-09 22:10 ` [PATCH net-next 2/2 v10] net: ethernet: Add a driver for Gemini gigabit ethernet Linus Walleij
2018-01-10 20:41 ` David Miller
2018-01-10 20:43 ` David Miller [this message]
2018-01-10 22:02 ` Linus Walleij
2018-01-10 20:40 ` [PATCH net-next 1/2 v10] net: ethernet: Add DT bindings for the Gemini ethernet David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110.154322.2235369645563224203.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=janos.dev@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=paulius.zaleckas@gmail.com \
--cc=tobias.waldvogel@gmail.com \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).