From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] nfp: always unmask aux interrupts at init Date: Wed, 10 Jan 2018 15:51:22 -0500 (EST) Message-ID: <20180110.155122.188378601064685594.davem@davemloft.net> References: <20180110021428.1706-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, oss-drivers@netronome.com To: jakub.kicinski@netronome.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:55196 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752415AbeAJUvY (ORCPT ); Wed, 10 Jan 2018 15:51:24 -0500 In-Reply-To: <20180110021428.1706-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jakub Kicinski Date: Tue, 9 Jan 2018 18:14:28 -0800 > The link state and exception interrupts may be masked when we probe. > The firmware should in theory prevent sending (and automasking) those > interrupts if the device is disabled, but if my reading of the FW code > is correct there are firmwares out there with race conditions in this > area. The interrupt may also be masked if previous driver which used > the device was malfunctioning and we didn't load the FW (there is no > other good way to comprehensively reset the PF). > > Note that FW unmasks the data interrupts by itself when vNIC is > enabled, such helpful operation is not performed for LSC/EXN interrupts. > > Always unmask the auxiliary interrupts after request_irq(). On the > remove path add missing PCI write flush before free_irq(). > > Fixes: 4c3523623dc0 ("net: add driver for Netronome NFP4000/NFP6000 NIC VFs") > Signed-off-by: Jakub Kicinski > Reviewed-by: Dirk van der Merwe Applied and queued up for -stable, thanks.