From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: [PATCH bpf-next 03/14] nfp: bpf: round up the size of the stack Date: Tue, 9 Jan 2018 21:07:31 -0800 Message-ID: <20180110050742.26226-4-jakub.kicinski@netronome.com> References: <20180110050742.26226-1-jakub.kicinski@netronome.com> Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, Jakub Kicinski To: daniel@iogearbox.net, alexei.starovoitov@gmail.com Return-path: Received: from mail-pg0-f66.google.com ([74.125.83.66]:43895 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751959AbeAJFIA (ORCPT ); Wed, 10 Jan 2018 00:08:00 -0500 Received: by mail-pg0-f66.google.com with SMTP id f14so7397040pga.10 for ; Tue, 09 Jan 2018 21:08:00 -0800 (PST) In-Reply-To: <20180110050742.26226-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: Kernel enforces the alignment of the bottom of the stack, NFP deals with positive offsets better so we should align the top of the stack. Round the stack size to NFP word size (4B). Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/bpf/offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/bpf/offload.c b/drivers/net/ethernet/netronome/nfp/bpf/offload.c index fa2905e67b07..8dbf13450bab 100644 --- a/drivers/net/ethernet/netronome/nfp/bpf/offload.c +++ b/drivers/net/ethernet/netronome/nfp/bpf/offload.c @@ -147,7 +147,7 @@ int nfp_bpf_translate(struct nfp_app *app, struct nfp_net *nn, return -EOPNOTSUPP; } - nfp_prog->stack_depth = prog->aux->stack_depth; + nfp_prog->stack_depth = round_up(prog->aux->stack_depth, 4); nfp_prog->start_off = nn_readw(nn, NFP_NET_CFG_BPF_START); nfp_prog->tgt_done = nn_readw(nn, NFP_NET_CFG_BPF_DONE); -- 2.15.1