From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2 v2 0/2] tests: fix issues in autopkgtest environment Date: Wed, 10 Jan 2018 08:31:14 -0800 Message-ID: <20180110083114.0bc55ae5@xeon-e3> References: <1515597097-870-1-git-send-email-christian.ehrhardt@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Netdev , Luca Boccassi To: Christian Ehrhardt Return-path: Received: from mail-pg0-f51.google.com ([74.125.83.51]:43694 "EHLO mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753734AbeAJQbW (ORCPT ); Wed, 10 Jan 2018 11:31:22 -0500 Received: by mail-pg0-f51.google.com with SMTP id f14so8635190pga.10 for ; Wed, 10 Jan 2018 08:31:22 -0800 (PST) In-Reply-To: <1515597097-870-1-git-send-email-christian.ehrhardt@canonical.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 10 Jan 2018 16:11:35 +0100 Christian Ehrhardt wrote: > Hi, > while working on Debian bug [1] and the Ubuntu counterpart of it > I found that the tests can throw a broken pipe warning. > > I kept the associated check-and-retry of the length separate to > discuss the changes individually - feel free to squash them on > commit if preferred. > > *Updates in v2* > tag with --subject-prefix='PATCH iproute2' to trigger the right > review queues in patchwork as requested by Luca Bocassi. > > [1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=879854 > > Christian Ehrhardt (2): > tests: read limited amount from /dev/urandom > tests: make sure rand_dev suffix has 6 chars > > testsuite/lib/generic.sh | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > Looks good. Applied. The method of generating a name seems a bit overly complex. Maybe using something like pwgen would be easier.