From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [PATCH bpf-next 1/2] net: use the right variant of kfree Date: Wed, 10 Jan 2018 11:58:26 +0100 Message-ID: <20180110115826.6793b1a6@redhat.com> References: <20180110092002.10420-1-jakub.kicinski@netronome.com> <20180110092002.10420-2-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, daniel@iogearbox.net, alexei.starovoitov@gmail.com, oss-drivers@netronome.com, brouer@redhat.com To: Jakub Kicinski Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36756 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755973AbeAJK6e (ORCPT ); Wed, 10 Jan 2018 05:58:34 -0500 In-Reply-To: <20180110092002.10420-2-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 10 Jan 2018 01:20:01 -0800 Jakub Kicinski wrote: > kvzalloc'ed memory should be kvfree'd. > > Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info") > Signed-off-by: Jakub Kicinski > Reviewed-by: Simon Horman > --- > net/core/dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/dev.c b/net/core/dev.c > index d7925ef8743d..852a54c769a3 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -7645,7 +7645,7 @@ static int netif_alloc_rx_queues(struct net_device *dev) > /* Rollback successful reg's and free other resources */ > while (i--) > xdp_rxq_info_unreg(&rx[i].xdp_rxq); > - kfree(dev->_rx); > + kvfree(dev->_rx); > dev->_rx = NULL; > return err; > } Thanks for catching this! Acked-by: Jesper Dangaard Brouer -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer