From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, daniel@iogearbox.net,
alexei.starovoitov@gmail.com, oss-drivers@netronome.com,
brouer@redhat.com
Subject: Re: [PATCH bpf-next 2/2] net: free RX queue structures
Date: Wed, 10 Jan 2018 11:59:11 +0100 [thread overview]
Message-ID: <20180110115911.7a98d3e9@redhat.com> (raw)
In-Reply-To: <20180110092002.10420-3-jakub.kicinski@netronome.com>
On Wed, 10 Jan 2018 01:20:02 -0800
Jakub Kicinski <jakub.kicinski@netronome.com> wrote:
> Looks like commit e817f85652c1 ("xdp: generic XDP handling of
> xdp_rxq_info") replaced kvfree(dev->_rx) in free_netdev() with
> a call to netif_free_rx_queues() which doesn't actually free
> the rings?
>
> While at it remove the unnecessary temporary variable.
>
> Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Reviewed-by: Simon Horman <simon.horman@netronome.com>
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
Thanks for fixing this!
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2018-01-10 10:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 9:20 [PATCH bpf-next 0/2] net: more fixes to the XDP RXQ series Jakub Kicinski
2018-01-10 9:20 ` [PATCH bpf-next 1/2] net: use the right variant of kfree Jakub Kicinski
2018-01-10 10:58 ` Jesper Dangaard Brouer
2018-01-10 9:20 ` [PATCH bpf-next 2/2] net: free RX queue structures Jakub Kicinski
2018-01-10 10:59 ` Jesper Dangaard Brouer [this message]
2018-01-10 11:10 ` [PATCH bpf-next 0/2] net: more fixes to the XDP RXQ series Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110115911.7a98d3e9@redhat.com \
--to=brouer@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).