From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [PATCH bpf-next 2/2] net: free RX queue structures Date: Wed, 10 Jan 2018 11:59:11 +0100 Message-ID: <20180110115911.7a98d3e9@redhat.com> References: <20180110092002.10420-1-jakub.kicinski@netronome.com> <20180110092002.10420-3-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, daniel@iogearbox.net, alexei.starovoitov@gmail.com, oss-drivers@netronome.com, brouer@redhat.com To: Jakub Kicinski Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39738 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932473AbeAJK7R (ORCPT ); Wed, 10 Jan 2018 05:59:17 -0500 In-Reply-To: <20180110092002.10420-3-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 10 Jan 2018 01:20:02 -0800 Jakub Kicinski wrote: > Looks like commit e817f85652c1 ("xdp: generic XDP handling of > xdp_rxq_info") replaced kvfree(dev->_rx) in free_netdev() with > a call to netif_free_rx_queues() which doesn't actually free > the rings? > > While at it remove the unnecessary temporary variable. > > Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info") > Signed-off-by: Jakub Kicinski > Reviewed-by: Simon Horman Acked-by: Jesper Dangaard Brouer Thanks for fixing this! -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer