From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [PATCH net-next] net/mlx5e: fix error return code in mlx5e_alloc_rq() Date: Wed, 10 Jan 2018 15:08:12 +0100 Message-ID: <20180110150812.4ced3f5a@redhat.com> References: <1515569453-63865-1-git-send-email-weiyongjun1@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Saeed Mahameed , Matan Barak , Leon Romanovsky , , , brouer@redhat.com To: Wei Yongjun Return-path: Received: from mx1.redhat.com ([209.132.183.28]:30653 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752108AbeAJOIV (ORCPT ); Wed, 10 Jan 2018 09:08:21 -0500 In-Reply-To: <1515569453-63865-1-git-send-email-weiyongjun1@huawei.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 10 Jan 2018 07:30:53 +0000 Wei Yongjun wrote: > Fix to return a negative error code from the xdp_rxq_info_reg() error > handling case instead of 0, as done elsewhere in this function. > > Fixes: 0ddf543226ac ("xdp/mlx5: setup xdp_rxq_info") > Signed-off-by: Wei Yongjun > --- > drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > index 539bd1d..6ba6671 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > @@ -582,7 +582,8 @@ static int mlx5e_alloc_rq(struct mlx5e_channel *c, > goto err_rq_wq_destroy; > } > > - if (xdp_rxq_info_reg(&rq->xdp_rxq, rq->netdev, rq->ix) < 0) > + err = xdp_rxq_info_reg(&rq->xdp_rxq, rq->netdev, rq->ix); > + if (err < 0) > goto err_rq_wq_destroy; > > rq->buff.map_dir = rq->xdp_prog ? DMA_BIDIRECTIONAL : DMA_FROM_DEVICE; Reviewed-by: Jesper Dangaard Brouer Thanks for fixing this. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer