netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guillaume Nault <g.nault@alphalink.fr>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, jchapman@katalix.com
Subject: Re: [PATCH net-next 3/3] l2tp: mark L2TP_ATTR_L2SPEC_LEN as not used
Date: Wed, 10 Jan 2018 18:59:03 +0100	[thread overview]
Message-ID: <20180110175903.GB1434@alphalink.fr> (raw)
In-Reply-To: <a6d962af4bd53f7376c5727497bf8c9c49540ba8.1515603824.git.lorenzo.bianconi@redhat.com>

On Wed, Jan 10, 2018 at 06:20:42PM +0100, Lorenzo Bianconi wrote:
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> ---
>  include/uapi/linux/l2tp.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/l2tp.h b/include/uapi/linux/l2tp.h
> index 71e62795104d..ec609a017691 100644
> --- a/include/uapi/linux/l2tp.h
> +++ b/include/uapi/linux/l2tp.h
> @@ -97,7 +97,7 @@ enum {
>  	L2TP_ATTR_OFFSET,		/* u16 (not used) */
>  	L2TP_ATTR_DATA_SEQ,		/* u16 */
>  	L2TP_ATTR_L2SPEC_TYPE,		/* u8, enum l2tp_l2spec_type */
> -	L2TP_ATTR_L2SPEC_LEN,		/* u8, enum l2tp_l2spec_type */
> +	L2TP_ATTR_L2SPEC_LEN,		/* u8, (not used) */
> 
Nitpick: if you repost this series, you can remove the comma between 'u8'
and '(not used)' (to keep the format used by L2TP_ATTR_OFFSET).

      reply	other threads:[~2018-01-10 17:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-10 17:20 [PATCH net-next 0/3] set l2specific_len based on l2specific_type Lorenzo Bianconi
2018-01-10 17:20 ` [PATCH net-next 1/3] l2tp: fix switch default error handling in l2tp_nl_cmd_session_create() Lorenzo Bianconi
2018-01-10 17:20 ` [PATCH net-next 2/3] l2tp: configure l2specific_len according to l2specific_type Lorenzo Bianconi
2018-01-10 17:55   ` Guillaume Nault
2018-01-10 18:06     ` Lorenzo Bianconi
2018-01-10 17:20 ` [PATCH net-next 3/3] l2tp: mark L2TP_ATTR_L2SPEC_LEN as not used Lorenzo Bianconi
2018-01-10 17:59   ` Guillaume Nault [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180110175903.GB1434@alphalink.fr \
    --to=g.nault@alphalink.fr \
    --cc=davem@davemloft.net \
    --cc=jchapman@katalix.com \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).