From: John Fastabend <john.fastabend@gmail.com>
To: borkmann@iogearbox.net, john.fastabend@gmail.com, ast@kernel.org
Cc: netdev@vger.kernel.org
Subject: [bpf-next PATCH v2 6/7] bpf: sockmap put client sockets in blocking mode
Date: Wed, 10 Jan 2018 10:40:27 -0800 [thread overview]
Message-ID: <20180110184027.5930.86884.stgit@john-Precision-Tower-5810> (raw)
In-Reply-To: <20180110183600.5930.68261.stgit@john-Precision-Tower-5810>
Put client sockets in blocking mode otherwise with sendmsg tests
its easy to overrun the socket buffers which results in the test
being aborted.
The original non-blocking was added to handle listen/accept with
a single thread the client/accepted sockets do not need to be
non-blocking.
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
---
samples/sockmap/sockmap_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/sockmap/sockmap_user.c b/samples/sockmap/sockmap_user.c
index eb19d14..9496b2c 100644
--- a/samples/sockmap/sockmap_user.c
+++ b/samples/sockmap/sockmap_user.c
@@ -110,7 +110,7 @@ static int sockmap_init_sockets(void)
}
/* Non-blocking sockets */
- for (i = 0; i < 4; i++) {
+ for (i = 0; i < 2; i++) {
err = ioctl(*fds[i], FIONBIO, (char *)&one);
if (err < 0) {
perror("ioctl s1 failed()");
next prev parent reply other threads:[~2018-01-10 18:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 18:38 [bpf-next PATCH v2 0/7] sockmap sample update John Fastabend
2018-01-10 18:39 ` [bpf-next PATCH v2 1/7] bpf: refactor sockmap sample program update for arg parsing John Fastabend
2018-01-11 1:25 ` Daniel Borkmann
2018-01-12 4:31 ` John Fastabend
2018-01-12 4:58 ` John Fastabend
2018-01-11 21:05 ` Martin KaFai Lau
2018-01-12 3:54 ` John Fastabend
2018-01-10 18:39 ` [bpf-next PATCH v2 2/7] bpf: add sendmsg option for testing BPF programs John Fastabend
2018-01-11 1:28 ` Daniel Borkmann
2018-01-11 21:08 ` Martin KaFai Lau
2018-01-10 18:39 ` [bpf-next PATCH v2 3/7] bpf: sockmap sample, use fork() for send and recv John Fastabend
2018-01-11 1:31 ` Daniel Borkmann
2018-01-12 4:33 ` John Fastabend
2018-01-11 21:08 ` Martin KaFai Lau
2018-01-12 3:57 ` John Fastabend
2018-01-10 18:39 ` [bpf-next PATCH v2 4/7] bpf: sockmap sample, report bytes/sec John Fastabend
2018-01-10 18:40 ` [bpf-next PATCH v2 5/7] bpf: sockmap sample add base test without any BPF for comparison John Fastabend
2018-01-11 21:10 ` Martin KaFai Lau
2018-01-12 4:03 ` John Fastabend
2018-01-10 18:40 ` John Fastabend [this message]
2018-01-10 18:40 ` [bpf-next PATCH v2 7/7] bpf: sockmap set rlimit John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110184027.5930.86884.stgit@john-Precision-Tower-5810 \
--to=john.fastabend@gmail.com \
--cc=ast@kernel.org \
--cc=borkmann@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox