From: Jiri Benc <jbenc@redhat.com>
To: William Tu <u9012063@gmail.com>
Cc: netdev@vger.kernel.org, Pravin B Shelar <pshelar@ovn.org>
Subject: Re: [PATCHv2 net-next 2/2] openvswitch: add erspan version II support
Date: Wed, 10 Jan 2018 22:29:56 +0100 [thread overview]
Message-ID: <20180110222956.3cde64ff@redhat.com> (raw)
In-Reply-To: <1515549082-4141-3-git-send-email-u9012063@gmail.com>
On Tue, 9 Jan 2018 17:51:22 -0800, William Tu wrote:
> --- a/include/uapi/linux/openvswitch.h
> +++ b/include/uapi/linux/openvswitch.h
> @@ -363,7 +373,8 @@ enum ovs_tunnel_key_attr {
> OVS_TUNNEL_KEY_ATTR_IPV6_SRC, /* struct in6_addr src IPv6 address. */
> OVS_TUNNEL_KEY_ATTR_IPV6_DST, /* struct in6_addr dst IPv6 address. */
> OVS_TUNNEL_KEY_ATTR_PAD,
> - OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS, /* be32 ERSPAN index. */
> + OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTSV1, /* be32 ERSPAN v1 index (deprecated). */
You can't do this in an uapi header, the existing name must stay the
same forever. Otherwise existing programs would suddenly stop to
compile.
Jiri
next prev parent reply other threads:[~2018-01-10 21:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 1:51 [PATCHv2 net-next 0/2] net: erspan: add support for openvswitch William Tu
2018-01-10 1:51 ` [PATCHv2 net-next 1/2] net: erspan: use bitfield instead of mask and offset William Tu
2018-01-10 1:51 ` [PATCHv2 net-next 2/2] openvswitch: add erspan version II support William Tu
2018-01-10 21:29 ` Jiri Benc [this message]
2018-01-10 21:35 ` Jiri Benc
2018-01-10 22:02 ` Jiri Benc
2018-01-11 16:34 ` William Tu
2018-01-12 8:27 ` Jiri Benc
2018-01-12 18:39 ` Pravin Shelar
2018-01-12 19:22 ` William Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110222956.3cde64ff@redhat.com \
--to=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).