From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Benc Subject: Re: [PATCHv2 net-next 2/2] openvswitch: add erspan version II support Date: Wed, 10 Jan 2018 22:29:56 +0100 Message-ID: <20180110222956.3cde64ff@redhat.com> References: <1515549082-4141-1-git-send-email-u9012063@gmail.com> <1515549082-4141-3-git-send-email-u9012063@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Pravin B Shelar To: William Tu Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60406 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753900AbeAJVaA (ORCPT ); Wed, 10 Jan 2018 16:30:00 -0500 In-Reply-To: <1515549082-4141-3-git-send-email-u9012063@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 9 Jan 2018 17:51:22 -0800, William Tu wrote: > --- a/include/uapi/linux/openvswitch.h > +++ b/include/uapi/linux/openvswitch.h > @@ -363,7 +373,8 @@ enum ovs_tunnel_key_attr { > OVS_TUNNEL_KEY_ATTR_IPV6_SRC, /* struct in6_addr src IPv6 address. */ > OVS_TUNNEL_KEY_ATTR_IPV6_DST, /* struct in6_addr dst IPv6 address. */ > OVS_TUNNEL_KEY_ATTR_PAD, > - OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS, /* be32 ERSPAN index. */ > + OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTSV1, /* be32 ERSPAN v1 index (deprecated). */ You can't do this in an uapi header, the existing name must stay the same forever. Otherwise existing programs would suddenly stop to compile. Jiri