From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, nogahf@mellanox.com, yuvalm@mellanox.com,
idosch@mellanox.com, mlxsw@mellanox.com, jhs@mojatatu.com,
xiyou.wangcong@gmail.com
Subject: Re: [patch net-next 1/5] mlxsw: reg: add rdpm register
Date: Thu, 11 Jan 2018 13:47:13 -0500 (EST) [thread overview]
Message-ID: <20180111.134713.1077073454608674334.davem@davemloft.net> (raw)
In-Reply-To: <20180111102102.4310-2-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 11 Jan 2018 11:20:58 +0100
> From: Yuval Mintz <yuvalm@mellanox.com>
>
> Add rdpm definition - router DSCP to priority mapping register.
>
> Signed-off-by: Yuval Mintz <yuvalm@mellanox.com>
> Signed-off-by: Nogah Frankel <nogahf@mellanox.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
This doesn't explain why adding a definition for this register...
> @@ -42,7 +42,7 @@
>
> struct mlxsw_item {
> unsigned short offset; /* bytes in container */
> - unsigned short step; /* step in bytes for indexed items */
> + short step; /* step in bytes for indexed items */
> unsigned short in_step_offset; /* offset within one step */
> unsigned char shift; /* shift in bits */
> unsigned char element_size; /* size of element in bit array */
requires making mlxsw_item->step signed.
Please update the commit message or move this change into a more
appropriate patch in this series or even a new one. Whichever
is required.
Thanks.
next prev parent reply other threads:[~2018-01-11 18:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 10:20 [patch net-next 0/5] mlxsw: Offload PRIO qdisc Jiri Pirko
2018-01-11 10:20 ` [patch net-next 1/5] mlxsw: reg: add rdpm register Jiri Pirko
2018-01-11 18:47 ` David Miller [this message]
2018-01-11 10:20 ` [patch net-next 2/5] mlxsw: spectrum_router: Configure default routing priority Jiri Pirko
2018-01-11 10:21 ` [patch net-next 3/5] net: sch: prio: Add offload ability to PRIO qdisc Jiri Pirko
2018-01-11 23:25 ` Jakub Kicinski
2018-01-11 23:50 ` Yuval Mintz
2018-01-12 0:00 ` Jakub Kicinski
2018-01-12 0:05 ` Yuval Mintz
2018-01-12 9:20 ` Nogah Frankel
2018-01-12 9:42 ` Jakub Kicinski
2018-01-11 10:21 ` [patch net-next 4/5] mlxsw: spectrum: qdiscs: Support PRIO qdisc offload Jiri Pirko
2018-01-11 10:21 ` [patch net-next 5/5] mlxsw: spectrum: qdiscs: Support stats for PRIO qdisc Jiri Pirko
2018-01-12 0:07 ` Jakub Kicinski
2018-01-12 0:39 ` Yuval Mintz
2018-01-12 8:32 ` Jakub Kicinski
2018-01-12 8:46 ` Yuval Mintz
2018-01-12 9:29 ` Nogah Frankel
2018-01-12 9:40 ` Jakub Kicinski
2018-01-12 10:26 ` Nogah Frankel
2018-01-12 13:27 ` [patch net-next 0/5] mlxsw: Offload " Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111.134713.1077073454608674334.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nogahf@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yuvalm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).