From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch net-next 1/5] mlxsw: reg: add rdpm register Date: Thu, 11 Jan 2018 13:47:13 -0500 (EST) Message-ID: <20180111.134713.1077073454608674334.davem@davemloft.net> References: <20180111102102.4310-1-jiri@resnulli.us> <20180111102102.4310-2-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, nogahf@mellanox.com, yuvalm@mellanox.com, idosch@mellanox.com, mlxsw@mellanox.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com To: jiri@resnulli.us Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:41374 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932703AbeAKSrR (ORCPT ); Thu, 11 Jan 2018 13:47:17 -0500 In-Reply-To: <20180111102102.4310-2-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: From: Jiri Pirko Date: Thu, 11 Jan 2018 11:20:58 +0100 > From: Yuval Mintz > > Add rdpm definition - router DSCP to priority mapping register. > > Signed-off-by: Yuval Mintz > Signed-off-by: Nogah Frankel > Signed-off-by: Jiri Pirko This doesn't explain why adding a definition for this register... > @@ -42,7 +42,7 @@ > > struct mlxsw_item { > unsigned short offset; /* bytes in container */ > - unsigned short step; /* step in bytes for indexed items */ > + short step; /* step in bytes for indexed items */ > unsigned short in_step_offset; /* offset within one step */ > unsigned char shift; /* shift in bits */ > unsigned char element_size; /* size of element in bit array */ requires making mlxsw_item->step signed. Please update the commit message or move this change into a more appropriate patch in this series or even a new one. Whichever is required. Thanks.