* [PATCH net-next] net: socionext: Fix error return code in netsec_netdev_open()
@ 2018-01-11 11:21 Wei Yongjun
2018-01-11 18:55 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2018-01-11 11:21 UTC (permalink / raw)
To: Jassi Brar; +Cc: Wei Yongjun, netdev, kernel-janitors
Fix to return error code -ENODEV from the of_phy_connect() error
handling case instead of 0, as done elsewhere in this function.
Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/socionext/netsec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
index a8edcf3..78e4ff6 100644
--- a/drivers/net/ethernet/socionext/netsec.c
+++ b/drivers/net/ethernet/socionext/netsec.c
@@ -1292,6 +1292,7 @@ static int netsec_netdev_open(struct net_device *ndev)
netsec_phy_adjust_link, 0,
priv->phy_interface)) {
netif_err(priv, link, priv->ndev, "missing PHY\n");
+ ret = -ENODEV;
goto err3;
}
} else {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: socionext: Fix error return code in netsec_netdev_open()
2018-01-11 11:21 [PATCH net-next] net: socionext: Fix error return code in netsec_netdev_open() Wei Yongjun
@ 2018-01-11 18:55 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-01-11 18:55 UTC (permalink / raw)
To: weiyongjun1; +Cc: jaswinder.singh, netdev, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Thu, 11 Jan 2018 11:21:38 +0000
> Fix to return error code -ENODEV from the of_phy_connect() error
> handling case instead of 0, as done elsewhere in this function.
>
> Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-11 18:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-11 11:21 [PATCH net-next] net: socionext: Fix error return code in netsec_netdev_open() Wei Yongjun
2018-01-11 18:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).