From: Jiri Pirko <jiri@resnulli.us>
To: David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch,
vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
michael.chan@broadcom.com, ganeshgr@chelsio.com,
saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com,
idosch@mellanox.com, jakub.kicinski@netronome.com,
simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com,
john.hurley@netronome.com, alexander.h.duyck@intel.com,
ogerlitz@mellanox.com, john.fastabend@gmail.com,
daniel@iogearbox.net
Subject: Re: [patch net-next v7 08/13] net: sched: add rt netlink message type for block get
Date: Thu, 11 Jan 2018 10:37:10 +0100 [thread overview]
Message-ID: <20180111093710.GA2053@nanopsycho.orion> (raw)
In-Reply-To: <9baf8774-cd25-4b85-fc29-a60a2972adf6@gmail.com>
Wed, Jan 10, 2018 at 05:48:09PM CET, dsahern@gmail.com wrote:
>On 1/9/18 7:07 AM, Jiri Pirko wrote:
>> diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
>> index 9c026d9..038cde7 100644
>> --- a/include/uapi/linux/rtnetlink.h
>> +++ b/include/uapi/linux/rtnetlink.h
>> @@ -150,6 +150,12 @@ enum {
>> RTM_NEWCACHEREPORT = 96,
>> #define RTM_NEWCACHEREPORT RTM_NEWCACHEREPORT
>>
>> + RTM_NEWBLOCK = 100,
>> +#define RTM_NEWBLOCK RTM_NEWBLOCK
>> + RTM_DELBLOCK,
>> +#define RTM_DELBLOCK RTM_DELBLOCK
>> + RTM_GETBLOCK,
>> +#define RTM_GETBLOCK RTM_GETBLOCK
>> __RTM_MAX,
>> #define RTM_MAX (((__RTM_MAX + 3) & ~3) - 1)
>> };
>
>Seems like this is creating an inconsistency. RTM_GETBLOCK is used to
>dump the set of shared blocks, but RTM_NEWBLOCK / RTM_DELBLOCK are not
>used to create / delete one.
Why is it a problem? RTM_NEWBLOCK is used as a reply for RTM_GETBLOCK.
I plan to have block notifications as a follow-up, there the RTM_GETBLOCK
and RTM_DELBLOCK will be used. The fact the user cannot create and
delete block explicitly is no problem in my opinion. The block creation
and deletion is done according to usage of qdiscs.
next prev parent reply other threads:[~2018-01-11 9:37 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 14:07 [patch net-next v7 00/13] net: sched: allow qdiscs to share filter block instances Jiri Pirko
2018-01-09 14:07 ` [patch net-next v7 01/13] net: sched: introduce support for multiple filter chain pointers registration Jiri Pirko
2018-01-09 14:07 ` [patch net-next v7 02/13] net: sched: introduce shared filter blocks infrastructure Jiri Pirko
2018-01-09 14:07 ` [patch net-next v7 03/13] net: sched: avoid usage of tp->q in tcf_classify Jiri Pirko
2018-01-10 16:17 ` David Ahern
2018-01-11 9:40 ` Jiri Pirko
2018-01-11 13:57 ` David Ahern
2018-01-09 14:07 ` [patch net-next v7 04/13] net: sched: introduce block mechanism to handle netif_keep_dst calls Jiri Pirko
2018-01-09 14:07 ` [patch net-next v7 05/13] net: sched: remove classid and q fields from tcf_proto Jiri Pirko
2018-01-09 14:07 ` [patch net-next v7 06/13] net: sched: keep track of offloaded filters and check tc offload feature Jiri Pirko
2018-01-09 14:07 ` [patch net-next v7 07/13] net: sched: use block index as a handle instead of qdisc when block is shared Jiri Pirko
2018-01-10 18:12 ` David Ahern
2018-01-11 9:38 ` Jiri Pirko
2018-01-11 13:25 ` Jamal Hadi Salim
2018-01-11 14:21 ` Jiri Pirko
2018-01-09 14:07 ` [patch net-next v7 08/13] net: sched: add rt netlink message type for block get Jiri Pirko
2018-01-10 16:48 ` David Ahern
2018-01-11 9:37 ` Jiri Pirko [this message]
2018-01-11 11:11 ` Jiri Pirko
2018-01-11 13:27 ` Jamal Hadi Salim
2018-01-11 14:23 ` Jiri Pirko
2018-01-09 14:07 ` [patch net-next v7 09/13] net: sched: allow ingress and clsact qdiscs to share filter blocks Jiri Pirko
2018-01-11 13:36 ` Jamal Hadi Salim
2018-01-11 14:24 ` Jiri Pirko
2018-01-11 14:37 ` Jamal Hadi Salim
2018-01-11 14:41 ` Jiri Pirko
2018-01-11 14:46 ` Jamal Hadi Salim
2018-01-11 15:07 ` Jiri Pirko
2018-01-11 15:41 ` Roopa Prabhu
2018-01-11 16:11 ` Jiri Pirko
2018-01-11 15:44 ` Jamal Hadi Salim
2018-01-11 16:15 ` Jiri Pirko
2018-01-11 17:02 ` Jamal Hadi Salim
2018-01-09 14:07 ` [patch net-next v7 10/13] mlxsw: spectrum_acl: Reshuffle code around mlxsw_sp_acl_ruleset_create/destroy Jiri Pirko
2018-01-09 14:07 ` [patch net-next v7 11/13] mlxsw: spectrum_acl: Don't store netdev and ingress for ruleset unbind Jiri Pirko
2018-01-09 14:07 ` [patch net-next v7 12/13] mlxsw: spectrum_acl: Implement TC block sharing Jiri Pirko
2018-01-09 14:07 ` [patch net-next v7 13/13] mlxsw: spectrum_acl: Pass mlxsw_sp_port down to ruleset bind/unbind ops Jiri Pirko
2018-01-09 14:19 ` [patch iproute2 net-next v7 1/3] include: update rtnetlink header according to kernel Jiri Pirko
2018-01-09 14:19 ` [patch iproute2 net-next v7 2/3] tc: introduce support for block-handle for filter operations Jiri Pirko
2018-01-09 14:19 ` [patch iproute2 net-next v7 3/3] tc: implement filter block sharing to ingress and clsact qdiscs Jiri Pirko
2018-01-11 13:19 ` [patch net-next v7 00/13] net: sched: allow qdiscs to share filter block instances Jamal Hadi Salim
2018-01-11 14:27 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111093710.GA2053@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=alexander.h.duyck@intel.com \
--cc=andrew@lunn.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=ganeshgr@chelsio.com \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=john.fastabend@gmail.com \
--cc=john.hurley@netronome.com \
--cc=leonro@mellanox.com \
--cc=matanb@mellanox.com \
--cc=michael.chan@broadcom.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=pieter.jansenvanvuuren@netronome.com \
--cc=saeedm@mellanox.com \
--cc=simon.horman@netronome.com \
--cc=vivien.didelot@savoirfairelinux.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).