From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next v7 03/13] net: sched: avoid usage of tp->q in tcf_classify Date: Thu, 11 Jan 2018 10:40:23 +0100 Message-ID: <20180111094023.GC2053@nanopsycho.orion> References: <20180109140731.1022-1-jiri@resnulli.us> <20180109140731.1022-4-jiri@resnulli.us> <8e52b826-c5b6-e144-b292-f7184d45f577@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com, ogerlitz@mellanox.com, john.fastabend@gmail.com, daniel@iogearbox.net To: David Ahern Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:40018 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754313AbeAKJkZ (ORCPT ); Thu, 11 Jan 2018 04:40:25 -0500 Received: by mail-wm0-f68.google.com with SMTP id f206so4073345wmf.5 for ; Thu, 11 Jan 2018 01:40:24 -0800 (PST) Content-Disposition: inline In-Reply-To: <8e52b826-c5b6-e144-b292-f7184d45f577@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Wed, Jan 10, 2018 at 05:17:28PM CET, dsahern@gmail.com wrote: >On 1/9/18 7:07 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Use block index in the messages instead. >> >> Signed-off-by: Jiri Pirko >> --- >> net/sched/cls_api.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c >> index 9b45950..31e91dc 100644 >> --- a/net/sched/cls_api.c >> +++ b/net/sched/cls_api.c >> @@ -672,8 +672,9 @@ int tcf_classify(struct sk_buff *skb, const struct tcf_proto *tp, >> #ifdef CONFIG_NET_CLS_ACT >> reset: >> if (unlikely(limit++ >= max_reclassify_loop)) { >> - net_notice_ratelimited("%s: reclassify loop, rule prio %u, protocol %02x\n", >> - tp->q->ops->id, tp->prio & 0xffff, >> + net_notice_ratelimited("%u: reclassify loop, rule prio %u, protocol %02x\n", > >if you are dumping index instead of prio shouldn't the 'rule prio' above >be adjusted? I'm not! Why do you think so? "%u:" is tp->chain->block->index "prio %u" is tp->prio & 0xffff "%02x" is ntohs(tp->protocol) > > >> + tp->chain->block->index, >> + tp->prio & 0xffff, >> ntohs(tp->protocol)); >> return TC_ACT_SHOT; >> } >> >