From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ahmed Abdelsalam <amsalam20@gmail.com>
Cc: kadlec@blackhole.kfki.hu, fw@strlen.de, davem@davemloft.net,
kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org
Subject: Re: [iptables] extensions: add support for 'srh' match
Date: Thu, 11 Jan 2018 13:17:44 +0100 [thread overview]
Message-ID: <20180111121744.5msbbjop4yvtn7ni@salvia> (raw)
In-Reply-To: <20180111111452.2ace1cdde68b3a11a2144a00@gmail.com>
On Thu, Jan 11, 2018 at 11:14:52AM +0100, Ahmed Abdelsalam wrote:
> On Wed, 10 Jan 2018 16:32:24 +0100
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
>
> > On Fri, Dec 29, 2017 at 12:08:25PM +0100, Ahmed Abdelsalam wrote:
> > > This patch adds a new exetension to iptables to supprt 'srh' match
> > > The implementation considers revision 7 of the SRH draft.
> > > https://tools.ietf.org/html/draft-ietf-6man-segment-routing-header-07
> > >
> > > Signed-off-by: Ahmed Abdelsalam <amsalam20@gmail.com>
> > > ---
> > > extensions/libip6t_srh.c | 283 ++++++++++++++++++++++++++++++++
> > > include/linux/netfilter_ipv6/ip6t_srh.h | 63 +++++++
> >
> > Please, add a extensions/libip6t_srh.t test file and send a v2.
> >
> > Thanks.
> Ok,
> Is there minimum requirements of the test cases to be added to the extensions/libip6t_srh.t file ?
I leave it up to you to decide what level of coverage you consider is
good to make sure that future changes don't break your new feature.
Thanks!
prev parent reply other threads:[~2018-01-11 12:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 11:08 [iptables] extensions: add support for 'srh' match Ahmed Abdelsalam
2018-01-10 15:32 ` Pablo Neira Ayuso
2018-01-11 10:14 ` Ahmed Abdelsalam
2018-01-11 12:17 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111121744.5msbbjop4yvtn7ni@salvia \
--to=pablo@netfilter.org \
--cc=amsalam20@gmail.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox