From: Jiri Benc <jbenc@redhat.com>
To: "Mahesh Bandewar (महेश बंडेवार) " <maheshb@google.com>
Cc: liuqifa@huawei.com, David Miller <davem@davemloft.net>,
dsahern@gmail.com, mschiffer@universe-factory.net,
idosch@mellanox.com, fw@strlen.de, kjlx@templeofstupid.com,
girish.moodalbail@oracle.com, sainath.grandhi@intel.com,
linux-netdev <netdev@vger.kernel.org>,
weiyongjun1@huawei.com, chenweilong@huawei.com,
maowenan@huawei.com, wangyufen@huawei.com, yuehaibing@huawei.com,
liujian56@huawei.com, liuzhe24@huawei.com,
wangkefeng.wang@huawei.com, dingtianhong@huawei.com
Subject: Re: [PATCH V2] ipvlan: fix ipvlan MTU limits
Date: Thu, 11 Jan 2018 12:25:54 +0100 [thread overview]
Message-ID: <20180111122554.45ff7de2@redhat.com> (raw)
In-Reply-To: <CAF2d9jhEqmtjWHkh6HP0e+69dKXtDiQ7LJBSMXVBMC=BtZEwUQ@mail.gmail.com>
On Wed, 10 Jan 2018 18:09:50 -0800, Mahesh Bandewar (महेश बंडेवार) wrote:
> I still prefer the approach I had mentioned that uses 'mtu_adj'. In
> that approach you can leave those slaves which have changed their mtu
> to be lower than masters' but if master's mtu changes to larger value
> all other slaves will get updated mtu leaving behind the slaves who
> have opted to change their mtu on their own. Also the same thing is
> true when mtu get reduced at master.
The problem with this magic behavior is, well, that it's magic. There's
no way to tell what happens with a given slave when the master's MTU
gets changed just by looking at the current configuration. There's also
no way to switch the magic behavior back on once the slave's MTU is
changed.
At minimum, you'd need some kind of indication that the slave's MTU is
following the master. And a way to toggle this back.
Keefe's patch is much saner, the behavior is completely deterministic.
Jiri
next prev parent reply other threads:[~2018-01-11 11:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 7:21 [PATCH V2] ipvlan: fix ipvlan MTU limits liuqifa
2018-01-11 2:09 ` Mahesh Bandewar (महेश बंडेवार)
2018-01-11 11:25 ` Jiri Benc [this message]
2018-01-11 16:59 ` Mahesh Bandewar (महेश बंडेवार)
2018-01-11 18:35 ` Mahesh Bandewar (महेश बंडेवार)
2018-01-12 8:34 ` Jiri Benc
2018-01-12 8:48 ` Jiri Benc
2018-01-12 17:50 ` Mahesh Bandewar (महेश बंडेवार)
2018-01-12 18:10 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111122554.45ff7de2@redhat.com \
--to=jbenc@redhat.com \
--cc=chenweilong@huawei.com \
--cc=davem@davemloft.net \
--cc=dingtianhong@huawei.com \
--cc=dsahern@gmail.com \
--cc=fw@strlen.de \
--cc=girish.moodalbail@oracle.com \
--cc=idosch@mellanox.com \
--cc=kjlx@templeofstupid.com \
--cc=liujian56@huawei.com \
--cc=liuqifa@huawei.com \
--cc=liuzhe24@huawei.com \
--cc=maheshb@google.com \
--cc=maowenan@huawei.com \
--cc=mschiffer@universe-factory.net \
--cc=netdev@vger.kernel.org \
--cc=sainath.grandhi@intel.com \
--cc=wangkefeng.wang@huawei.com \
--cc=wangyufen@huawei.com \
--cc=weiyongjun1@huawei.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).