From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next v7 07/13] net: sched: use block index as a handle instead of qdisc when block is shared Date: Thu, 11 Jan 2018 15:21:53 +0100 Message-ID: <20180111142153.GH2053@nanopsycho.orion> References: <20180109140731.1022-1-jiri@resnulli.us> <20180109140731.1022-8-jiri@resnulli.us> <243389ac-25d8-a75e-3092-fd234333ec8b@mojatatu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com, ogerlitz@mellanox.com, john.fastabend@gmail.com, daniel@iogearbox.net, dsahern@gmail.com To: Jamal Hadi Salim Return-path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:40871 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754252AbeAKOVz (ORCPT ); Thu, 11 Jan 2018 09:21:55 -0500 Received: by mail-wm0-f67.google.com with SMTP id f206so5727717wmf.5 for ; Thu, 11 Jan 2018 06:21:54 -0800 (PST) Content-Disposition: inline In-Reply-To: <243389ac-25d8-a75e-3092-fd234333ec8b@mojatatu.com> Sender: netdev-owner@vger.kernel.org List-ID: Thu, Jan 11, 2018 at 02:25:36PM CET, jhs@mojatatu.com wrote: >On 18-01-09 09:07 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> As the tcm_ifindex 0 is invalid ifindex, reuse it to indicate that we >> work with block, instead of qdisc. So if tcm_ifindex is 0, tcm_parent is >> used to carry block_index. >> > >Commit log still refers to ifindex of 0 instead of TCM_IFINDEX_MAGIC_BLOCK Missed this. Will update, thanks!