From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next v7 09/13] net: sched: allow ingress and clsact qdiscs to share filter blocks Date: Thu, 11 Jan 2018 15:24:57 +0100 Message-ID: <20180111142457.GJ2053@nanopsycho.orion> References: <20180109140731.1022-1-jiri@resnulli.us> <20180109140731.1022-10-jiri@resnulli.us> <66883304-2004-7154-4700-9839203cecff@mojatatu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com, ogerlitz@mellanox.com, john.fastabend@gmail.com, daniel@iogearbox.net, dsahern@gmail.com To: Jamal Hadi Salim Return-path: Received: from mail-wr0-f193.google.com ([209.85.128.193]:37775 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932841AbeAKOY7 (ORCPT ); Thu, 11 Jan 2018 09:24:59 -0500 Received: by mail-wr0-f193.google.com with SMTP id f8so2321745wre.4 for ; Thu, 11 Jan 2018 06:24:58 -0800 (PST) Content-Disposition: inline In-Reply-To: <66883304-2004-7154-4700-9839203cecff@mojatatu.com> Sender: netdev-owner@vger.kernel.org List-ID: Thu, Jan 11, 2018 at 02:36:01PM CET, jhs@mojatatu.com wrote: >On 18-01-09 09:07 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Benefit from the previously introduced shared filter blocks >> infrastructure and allow ingress and clsact qdisc instances to share >> filter blocks. The block index is coming from userspace as qdisc option. > >Didnt quiet follow why ingress is special and needs attributes to >set the block but other qdiscs didnt. Jamal, again, other qdiscs does not support block sharing. This patchset only adds support for sharing of block for ingress and clsact qdiscs. Later on, other qdiscs could also support block sharing. >Will check again later after some coffee.. > >cheers, >jamal