From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [patch net-next 3/5] net: sch: prio: Add offload ability to PRIO qdisc Date: Thu, 11 Jan 2018 15:25:37 -0800 Message-ID: <20180111152537.3a90c722@cakuba.netronome.com> References: <20180111102102.4310-1-jiri@resnulli.us> <20180111102102.4310-4-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, nogahf@mellanox.com, yuvalm@mellanox.com, davem@davemloft.net, idosch@mellanox.com, mlxsw@mellanox.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com To: Jiri Pirko Return-path: Received: from mx4.wp.pl ([212.77.101.12]:45252 "EHLO mx4.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750782AbeAKXZq (ORCPT ); Thu, 11 Jan 2018 18:25:46 -0500 In-Reply-To: <20180111102102.4310-4-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 11 Jan 2018 11:21:00 +0100, Jiri Pirko wrote: > +struct tc_prio_qopt_offload_params { > + int bands; > + u8 priomap[TC_PRIO_MAX + 1]; > + /* In case that a prio qdisc is offloaded and now is changed to a > + * non-offloadedable config, it needs to update the backlog value > + * to negate the HW backlog value. > + */ > + u32 *backlog; > +}; Could we please pass the full qstats on replace and destroy. This simplifies the driver code and allows handling the qlen as well as backlog. Please see the 2 patch series I sent earlier yesterday.