From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [patch net-next 3/5] net: sch: prio: Add offload ability to PRIO qdisc Date: Thu, 11 Jan 2018 16:00:13 -0800 Message-ID: <20180111160013.6f523996@cakuba.netronome.com> References: <20180111102102.4310-1-jiri@resnulli.us> <20180111102102.4310-4-jiri@resnulli.us> <20180111152537.3a90c722@cakuba.netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Jiri Pirko , "netdev@vger.kernel.org" , Nogah Frankel , "davem@davemloft.net" , "Ido Schimmel" , mlxsw , "jhs@mojatatu.com" , "xiyou.wangcong@gmail.com" To: Yuval Mintz Return-path: Received: from mx3.wp.pl ([212.77.101.10]:19033 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932068AbeALAAV (ORCPT ); Thu, 11 Jan 2018 19:00:21 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 11 Jan 2018 23:50:27 +0000, Yuval Mintz wrote: > > > +struct tc_prio_qopt_offload_params { > > > + int bands; > > > + u8 priomap[TC_PRIO_MAX + 1]; > > > + /* In case that a prio qdisc is offloaded and now is changed to a > > > + * non-offloadedable config, it needs to update the backlog value > > > + * to negate the HW backlog value. > > > + */ > > > + u32 *backlog; > > > +}; > > > > Could we please pass the full qstats on replace and destroy. This > > simplifies the driver code and allows handling the qlen as well as > > backlog. Please see the 2 patch series I sent earlier yesterday. > > That might give the false impression that offloading driver is expected > to correct all the qstats fields during destruction, whereas for most of > them it doesn't seem appropriate. The driver is supposed to return the momentary stats to their original/SW-only value. And the driver knows exactly which stats those are, just look at your patch 5, you handle backlog completely differently than other stats already.