From: Jakub Kicinski <kubakici@wp.pl>
To: Yuval Mintz <yuvalm@mellanox.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Nogah Frankel <nogahf@mellanox.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"Ido Schimmel" <idosch@mellanox.com>, mlxsw <mlxsw@mellanox.com>,
"jhs@mojatatu.com" <jhs@mojatatu.com>,
"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>
Subject: Re: [patch net-next 5/5] mlxsw: spectrum: qdiscs: Support stats for PRIO qdisc
Date: Fri, 12 Jan 2018 00:32:30 -0800 [thread overview]
Message-ID: <20180112003230.2f00e36a@laptop> (raw)
In-Reply-To: <VI1PR05MB35201776F2FCD9F7821B1962BF170@VI1PR05MB3520.eurprd05.prod.outlook.com>
On Fri, 12 Jan 2018 00:39:26 +0000 Yuval Mintz wrote:
> > Hm. You you need this just because you didn't add the backlog
> > pointer to destroy? AFAIK on destroy we are free to reset stats as
> > well, thus simplifying your driver... Let me know if I
> > misunderstand.
>
> This is meant exactly for the scenario where qdisc didn't get
> destroyed yet is no longer offloaded; E.g., if number of bands
> increased beyond What we can offload. So we can't reset the
> statistics in this case. [Although I might be the one to
> misunderstand you, as the 'not destroyed' was explicitly mentioned
> twice above]
I was trying to take some liberty with handling of destroy but your
approach may actually end up being simpler. I will withdraw my series
for now and reuse your new callback once this series lands.
Do you have any objections to changing RED to behave more like prio
(and other qdiscs) in principle?
next prev parent reply other threads:[~2018-01-12 8:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 10:20 [patch net-next 0/5] mlxsw: Offload PRIO qdisc Jiri Pirko
2018-01-11 10:20 ` [patch net-next 1/5] mlxsw: reg: add rdpm register Jiri Pirko
2018-01-11 18:47 ` David Miller
2018-01-11 10:20 ` [patch net-next 2/5] mlxsw: spectrum_router: Configure default routing priority Jiri Pirko
2018-01-11 10:21 ` [patch net-next 3/5] net: sch: prio: Add offload ability to PRIO qdisc Jiri Pirko
2018-01-11 23:25 ` Jakub Kicinski
2018-01-11 23:50 ` Yuval Mintz
2018-01-12 0:00 ` Jakub Kicinski
2018-01-12 0:05 ` Yuval Mintz
2018-01-12 9:20 ` Nogah Frankel
2018-01-12 9:42 ` Jakub Kicinski
2018-01-11 10:21 ` [patch net-next 4/5] mlxsw: spectrum: qdiscs: Support PRIO qdisc offload Jiri Pirko
2018-01-11 10:21 ` [patch net-next 5/5] mlxsw: spectrum: qdiscs: Support stats for PRIO qdisc Jiri Pirko
2018-01-12 0:07 ` Jakub Kicinski
2018-01-12 0:39 ` Yuval Mintz
2018-01-12 8:32 ` Jakub Kicinski [this message]
2018-01-12 8:46 ` Yuval Mintz
2018-01-12 9:29 ` Nogah Frankel
2018-01-12 9:40 ` Jakub Kicinski
2018-01-12 10:26 ` Nogah Frankel
2018-01-12 13:27 ` [patch net-next 0/5] mlxsw: Offload " Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112003230.2f00e36a@laptop \
--to=kubakici@wp.pl \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nogahf@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yuvalm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).