From: Jakub Kicinski <kubakici@wp.pl>
To: Nogah Frankel <nogahf@mellanox.com>
Cc: Yuval Mintz <yuvalm@mellanox.com>, Jiri Pirko <jiri@resnulli.us>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"Ido Schimmel" <idosch@mellanox.com>, mlxsw <mlxsw@mellanox.com>,
"jhs@mojatatu.com" <jhs@mojatatu.com>,
"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>
Subject: Re: [patch net-next 3/5] net: sch: prio: Add offload ability to PRIO qdisc
Date: Fri, 12 Jan 2018 01:42:16 -0800 [thread overview]
Message-ID: <20180112014216.396904f3@laptop> (raw)
In-Reply-To: <DB5PR05MB18955C7EA9DC6CD7D00C4764AC170@DB5PR05MB1895.eurprd05.prod.outlook.com>
On Fri, 12 Jan 2018 09:20:46 +0000
Nogah Frankel <nogahf@mellanox.com> wrote:
> > > > > Could we please pass the full qstats on replace and destroy.
> > > > > This simplifies the driver code and allows handling the qlen
> > > > > as well as backlog. Please see the 2 patch series I sent
> > > > > earlier yesterday.
>
> On replace - no problem.
> On destroy, I think it is redundant because the qdisc is going to be
> deleted anyway.
Right, the hope was it wouldn't matter and could make the code easier
to follow, but the replace with new qdisc complicates things.
> (To make sure that we are on the same page, if replace in the HW
> fails, we "rollback" only the backlog and qlen. The rest of the
> counters like TX count should reflect the number of the packets that
> passed in the HW while this qdisc was offloaded)
Agreed!
next prev parent reply other threads:[~2018-01-12 9:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 10:20 [patch net-next 0/5] mlxsw: Offload PRIO qdisc Jiri Pirko
2018-01-11 10:20 ` [patch net-next 1/5] mlxsw: reg: add rdpm register Jiri Pirko
2018-01-11 18:47 ` David Miller
2018-01-11 10:20 ` [patch net-next 2/5] mlxsw: spectrum_router: Configure default routing priority Jiri Pirko
2018-01-11 10:21 ` [patch net-next 3/5] net: sch: prio: Add offload ability to PRIO qdisc Jiri Pirko
2018-01-11 23:25 ` Jakub Kicinski
2018-01-11 23:50 ` Yuval Mintz
2018-01-12 0:00 ` Jakub Kicinski
2018-01-12 0:05 ` Yuval Mintz
2018-01-12 9:20 ` Nogah Frankel
2018-01-12 9:42 ` Jakub Kicinski [this message]
2018-01-11 10:21 ` [patch net-next 4/5] mlxsw: spectrum: qdiscs: Support PRIO qdisc offload Jiri Pirko
2018-01-11 10:21 ` [patch net-next 5/5] mlxsw: spectrum: qdiscs: Support stats for PRIO qdisc Jiri Pirko
2018-01-12 0:07 ` Jakub Kicinski
2018-01-12 0:39 ` Yuval Mintz
2018-01-12 8:32 ` Jakub Kicinski
2018-01-12 8:46 ` Yuval Mintz
2018-01-12 9:29 ` Nogah Frankel
2018-01-12 9:40 ` Jakub Kicinski
2018-01-12 10:26 ` Nogah Frankel
2018-01-12 13:27 ` [patch net-next 0/5] mlxsw: Offload " Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112014216.396904f3@laptop \
--to=kubakici@wp.pl \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nogahf@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yuvalm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox