From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Benc <jbenc@redhat.com>
Subject: Re: [PATCH V2] ipvlan: fix ipvlan MTU limits
Date: Fri, 12 Jan 2018 09:34:13 +0100
Message-ID: <20180112093413.683560bf@redhat.com>
References: <20180110072149.8804-1-liuqifa@huawei.com>
        <CAF2d9jhEqmtjWHkh6HP0e+69dKXtDiQ7LJBSMXVBMC=BtZEwUQ@mail.gmail.com>
        <20180111122554.45ff7de2@redhat.com>
        <CAF2d9ji5yj-M8etHVZU8WOUz8ivjyk=_y=obOOxG9OB3Vdk+wg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Cc: liuqifa@huawei.com, David Miller <davem@davemloft.net>,
        dsahern@gmail.com, mschiffer@universe-factory.net,
        idosch@mellanox.com, fw@strlen.de, kjlx@templeofstupid.com,
        girish.moodalbail@oracle.com, sainath.grandhi@intel.com,
        linux-netdev <netdev@vger.kernel.org>, weiyongjun1@huawei.com,
        chenweilong@huawei.com, maowenan@huawei.com, wangyufen@huawei.com,
        yuehaibing@huawei.com, liujian56@huawei.com, liuzhe24@huawei.com,
        wangkefeng.wang@huawei.com, dingtianhong@huawei.com
To: "Mahesh Bandewar (=?UTF-8?B?4KSu4KS54KWH4KS2IOCkrOCkguCkoeClh+CktQ==?=
        =?UTF-8?B?4KS+4KSw?=)" <maheshb@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:58026 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754255AbeALIeZ (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 12 Jan 2018 03:34:25 -0500
In-Reply-To: <CAF2d9ji5yj-M8etHVZU8WOUz8ivjyk=_y=obOOxG9OB3Vdk+wg@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, 11 Jan 2018 08:59:58 -0800, Mahesh Bandewar (महेश बंडेवार) wrote:
> I guess the logic would be as simple as - if mtu_adj for a slave is
> set to 0, then it's
> following master otherwise not. By setting different mtu for a slave, you will
> set this mtu_adj a positive number which would mean it's not following master.
> So it's subjected to clamping when masters' mtu is reducing but should stay
> otherwise. Also when slave decides to follow master again, it can set the mtu
> to be same as masters' (making mtu_adj == 0) and then it would start following
> master again.

How can the mtu_adj value be queried and set from user space?

> Whether it's magic or not, it's the current behavior and I know several use
> cases depend on this behavior which would be broken otherwise. The
> approach I proposed keeps that going for those who depend on that while
> adds an ability to set mtu per slave for the use case mentioned in this
> patch-set too.

I don't think this works currently. When someone (does not have to be
you, it can be a management software running in background) sets the
MTU to the current value, the magic behavior is lost without any way to
restore it (unless I'm missing a way to restore it, see my question
above). So any user that depends on the magic behavior is broken anyway
even now.

 Jiri