From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Benc <jbenc@redhat.com>
Subject: Re: [PATCH V2] ipvlan: fix ipvlan MTU limits
Date: Fri, 12 Jan 2018 09:48:33 +0100
Message-ID: <20180112094833.70926efa@redhat.com>
References: <20180110072149.8804-1-liuqifa@huawei.com>
        <CAF2d9jhEqmtjWHkh6HP0e+69dKXtDiQ7LJBSMXVBMC=BtZEwUQ@mail.gmail.com>
        <20180111122554.45ff7de2@redhat.com>
        <CAF2d9ji5yj-M8etHVZU8WOUz8ivjyk=_y=obOOxG9OB3Vdk+wg@mail.gmail.com>
        <20180112093413.683560bf@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: liuqifa@huawei.com, David Miller <davem@davemloft.net>,
        dsahern@gmail.com, mschiffer@universe-factory.net,
        idosch@mellanox.com, fw@strlen.de, kjlx@templeofstupid.com,
        girish.moodalbail@oracle.com, sainath.grandhi@intel.com,
        linux-netdev <netdev@vger.kernel.org>, weiyongjun1@huawei.com,
        chenweilong@huawei.com, maowenan@huawei.com, wangyufen@huawei.com,
        yuehaibing@huawei.com, liujian56@huawei.com, liuzhe24@huawei.com,
        wangkefeng.wang@huawei.com, dingtianhong@huawei.com
To: "Mahesh Bandewar (=?UTF-8?B?4KSu4KS54KWH4KS2IOCkrOCkguCkoeClh+CktQ==?=
        =?UTF-8?B?4KS+4KSw?=)" <maheshb@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:39170 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754697AbeALIsq (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 12 Jan 2018 03:48:46 -0500
In-Reply-To: <20180112093413.683560bf@redhat.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, 12 Jan 2018 09:34:13 +0100, Jiri Benc wrote:
> I don't think this works currently. When someone (does not have to be
> you, it can be a management software running in background) sets the
> MTU to the current value, the magic behavior is lost without any way to
> restore it (unless I'm missing a way to restore it, see my question
> above). So any user that depends on the magic behavior is broken anyway
> even now.

Upon further inspection, it seems that currently, slaves always follow
master's MTU without a way to change it. Tough situation. Even
implementing user space toggleable mtu_adj could break users in the way
I described. But it seems to be the lesser evil, at least there would
be a way to unbreak the scripts with one line addition.

But it's absolute must to have this visible to the user space and
changeable. Something like this:

# ip a
123: ipvlan0: <FLAGS> mtu 1500 (auto) qdisc ...
# ip l s ipvlan0 mtu 1400
# ip a
123: ipvlan0: <FLAGS> mtu 1400 qdisc ...
# ip l s ipvlan0 mtu auto
# ip a
123: ipvlan0: <FLAGS> mtu 1500 (auto) qdisc ...

 Jiri