From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Subject: Re: [PATCH v2] bnx2x: disable GSO where gso_size is too big for
 hardware
Date: Fri, 12 Jan 2018 09:53:23 -0200
Message-ID: <20180112115323.GA19162@localhost.localdomain>
References: <20180111235905.10110-1-dja@axtens.net>
 <20180112114844.GN725@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org,
        Thomas Falcon <tlfalcon@linux.vnet.ibm.com>,
        Yuval Mintz <Yuval.Mintz@cavium.com>
To: Daniel Axtens <dja@axtens.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:36728 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754403AbeALLxl (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 12 Jan 2018 06:53:41 -0500
Content-Disposition: inline
In-Reply-To: <20180112114844.GN725@localhost.localdomain>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, Jan 12, 2018 at 09:48:44AM -0200, Marcelo Ricardo Leitner wrote:
> On Fri, Jan 12, 2018 at 10:59:05AM +1100, Daniel Axtens wrote:
> > If a bnx2x card is passed a GSO packet with a gso_size larger than
> > ~9700 bytes, it will cause a firmware error that will bring the card
> > down:
> 
> Why not use netif_set_gso_max_size() instead?
> Some drivers are using it to avoid such larger than supported packets.

Scratch that, sorry. It doesn't take effect in forwarding path.

  Marcelo