From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eyal Birger <eyal.birger@gmail.com>
Cc: netdev@vger.kernel.org, Jamal Hadi Salim <jhs@mojatatu.com>,
coreteam@netfilter.org, shmulik@metanetworks.com,
Eyal Birger <eyal@metanetworks.com>
Subject: Re: [PATCH net-next 1/2] net: netfilter: export xt_policy match_policy_in() as xt_policy_match_policy_in()
Date: Fri, 12 Jan 2018 15:00:53 +0100 [thread overview]
Message-ID: <20180112140053.aqykalueijqrvisd@salvia> (raw)
In-Reply-To: <CAHsH6GtuKyBHdUk5CoA_U6tNX9dbhhLO0jVsX2Jw5zaVHOoM8A@mail.gmail.com>
On Fri, Jan 12, 2018 at 03:56:21PM +0200, Eyal Birger wrote:
> On Fri, Jan 12, 2018 at 3:41 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Fri, Jan 12, 2018 at 02:57:24PM +0200, Eyal Birger wrote:
> >> @@ -51,9 +52,9 @@ match_xfrm_state(const struct xfrm_state *x, const struct xt_policy_elem *e,
> >> MATCH(reqid, x->props.reqid);
> >> }
> >>
> >> -static int
> >> -match_policy_in(const struct sk_buff *skb, const struct xt_policy_info *info,
> >> - unsigned short family)
> >> +int xt_policy_match_policy_in(const struct sk_buff *skb,
> >> + const struct xt_policy_info *info,
> >> + unsigned short family)
> >> {
> >> const struct xt_policy_elem *e;
> >> const struct sec_path *sp = skb->sp;
> >> @@ -80,10 +81,11 @@ match_policy_in(const struct sk_buff *skb, const struct xt_policy_info *info,
> >>
> >> return strict ? 1 : 0;
> >> }
> >> +EXPORT_SYMBOL_GPL(xt_policy_match_policy_in);
> >
> > If you just want to call xt_policy_match from tc, then you could use
> > tc ipt infrastructure instead.
>
> Thanks for the suggestion -
> Are you referring to act_ipt? it looks like it allows calling targets;
> I couldn't find a classifier calling a netfilter matcher.
Then, I'd suggest you extend that infrastructure to alllow to call
matches, so we reduce the number of interdepencies between different
subsystems.
next prev parent reply other threads:[~2018-01-12 14:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 12:57 [PATCH net-next 0/2] net: sched: Introduce em_policy ematch Eyal Birger
2018-01-12 12:57 ` [PATCH net-next 1/2] net: netfilter: export xt_policy match_policy_in() as xt_policy_match_policy_in() Eyal Birger
2018-01-12 13:41 ` Pablo Neira Ayuso
2018-01-12 13:56 ` Eyal Birger
2018-01-12 14:00 ` Pablo Neira Ayuso [this message]
2018-01-14 12:47 ` Eyal Birger
2018-01-15 10:57 ` Pablo Neira Ayuso
2018-01-15 11:48 ` Eyal Birger
2018-02-14 8:14 ` Eyal Birger
2018-02-14 10:19 ` Pablo Neira Ayuso
2018-02-15 17:47 ` Eyal Birger
2018-01-12 12:57 ` [PATCH net-next 2/2] net: sched: add xfrm policy ematch Eyal Birger
2018-01-16 6:30 ` Cong Wang
2018-01-16 18:17 ` Eyal Birger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112140053.aqykalueijqrvisd@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=eyal.birger@gmail.com \
--cc=eyal@metanetworks.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=shmulik@metanetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox