From: Martin KaFai Lau <kafai@fb.com>
To: John Fastabend <john.fastabend@gmail.com>
Cc: <borkmann@iogearbox.net>, <ast@kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [bpf-next PATCH v3 3/7] bpf: sockmap sample, use fork() for send and recv
Date: Fri, 12 Jan 2018 23:31:51 -0800 [thread overview]
Message-ID: <20180113073151.v3ak6ra5465x7epu@kafai-mbp> (raw)
In-Reply-To: <20180112050654.5823.91255.stgit@john-Precision-Tower-5810>
On Thu, Jan 11, 2018 at 09:06:54PM -0800, John Fastabend wrote:
> Currently for SENDMSG tests first send completes then recv runs. This
> does not work well for large data sizes and/or many iterations. So
> fork the recv and send handler so that we run both send and recv. In
> the future we can add a parameter to do more than a single fork of
> tx/rx.
>
> With this we can get many GBps of data which helps exercise the
> sockmap code.
>
> Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Some nits.
Acked-by: Martin KaFai Lau <kafai@fb.com>
> ---
[ ... ]
> @@ -274,25 +275,50 @@ static int msg_loop(int fd, int iov_count, int iov_length, int cnt,
>
> static int sendmsg_test(int iov_count, int iov_buf, int cnt, int verbose)
> {
> + int txpid, rxpid, err = 0;
> struct msg_stats s = {0};
> - int err;
> -
> - err = msg_loop(c1, iov_count, iov_buf, cnt, &s, true);
> - if (err) {
> - fprintf(stderr,
> - "msg_loop_tx: iov_count %i iov_buf %i cnt %i err %i\n",
> - iov_count, iov_buf, cnt, err);
> - return err;
> + int status;
> +
> + errno = 0;
> +
> + rxpid = fork();
> + if (rxpid == 0) {
> + err = msg_loop(p2, iov_count, iov_buf, cnt, &s, false);
> + if (err)
> + fprintf(stderr,
> + "msg_loop_rx: iov_count %i iov_buf %i cnt %i err %i\n",
> + iov_count, iov_buf, cnt, err);
> + fprintf(stdout, "rx_sendmsg: TX_bytes %zu RX_bytes %zu\n",
> + s.bytes_sent, s.bytes_recvd);
> + shutdown(p2, SHUT_RDWR);
> + shutdown(p1, SHUT_RDWR);
> + exit(1);
> + } else if (rxpid == -1) {
> + perror("msg_loop_rx: ");
> + return errno;
> }
>
> - msg_loop(p2, iov_count, iov_buf, cnt, &s, false);
> - if (err)
> - fprintf(stderr,
> - "msg_loop_rx: iov_count %i iov_buf %i cnt %i err %i\n",
> - iov_count, iov_buf, cnt, err);
> + txpid = fork();
> + if (txpid == 0) {
> + err = msg_loop(c1, iov_count, iov_buf, cnt, &s, true);
> + if (err)
> + fprintf(stderr,
> + "msg_loop_tx: iov_count %i iov_buf %i cnt %i err %i\n",
> + iov_count, iov_buf, cnt, err);
> + fprintf(stdout, "tx_sendmsg: TX_bytes %zu RX_bytes %zu\n",
> + s.bytes_sent, s.bytes_recvd);
> + shutdown(c1, SHUT_RDWR);
> + exit(1);
> + } else if (txpid == -1) {
> + perror("msg_loop_tx: ");
> + return errno;
> + }
>
> - fprintf(stdout, "sendmsg: TX_bytes %zu RX_bytes %zu\n",
> - s.bytes_sent, s.bytes_recvd);
> + assert(waitpid(rxpid, &status, 0) == rxpid);
> + if (!txpid)
This case won't be hit?
> + goto out;
> + assert(waitpid(txpid, &status, 0) == txpid);
> +out:
> return err;
> }
>
>
next prev parent reply other threads:[~2018-01-13 7:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 5:06 [bpf-next PATCH v3 0/7] sockmap sample update John Fastabend
2018-01-12 5:06 ` [bpf-next PATCH v3 1/7] bpf: refactor sockmap sample program update for arg parsing John Fastabend
2018-01-13 7:19 ` Martin KaFai Lau
2018-01-12 5:06 ` [bpf-next PATCH v3 2/7] bpf: add sendmsg option for testing BPF programs John Fastabend
2018-01-13 7:30 ` Martin KaFai Lau
2018-01-12 5:06 ` [bpf-next PATCH v3 3/7] bpf: sockmap sample, use fork() for send and recv John Fastabend
2018-01-13 7:31 ` Martin KaFai Lau [this message]
2018-01-13 7:33 ` Martin KaFai Lau
2018-01-12 5:07 ` [bpf-next PATCH v3 4/7] bpf: sockmap sample, report bytes/sec John Fastabend
2018-01-13 7:34 ` Martin KaFai Lau
2018-01-12 5:07 ` [bpf-next PATCH v3 5/7] bpf: sockmap sample add base test without any BPF for comparison John Fastabend
2018-01-13 7:34 ` Martin KaFai Lau
2018-01-12 5:07 ` [bpf-next PATCH v3 6/7] bpf: sockmap put client sockets in blocking mode John Fastabend
2018-01-13 7:34 ` Martin KaFai Lau
2018-01-12 5:08 ` [bpf-next PATCH v3 7/7] bpf: sockmap set rlimit John Fastabend
2018-01-13 7:35 ` Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180113073151.v3ak6ra5465x7epu@kafai-mbp \
--to=kafai@fb.com \
--cc=ast@kernel.org \
--cc=borkmann@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox