* [PATCH] sh_eth: dix dumping ARSTR
@ 2018-01-13 17:22 Sergei Shtylyov
2018-01-13 17:23 ` Sergei Shtylyov
2018-01-15 19:51 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2018-01-13 17:22 UTC (permalink / raw)
To: netdev, linux-renesas-soc; +Cc: linux-sh, Sergei Shtylyov
[-- Attachment #1: sh_eth-fix-dumping-ARSTR.patch --]
[-- Type: text/plain, Size: 1000 bytes --]
ARSTR is always located at the start of the TSU register region, thus
using add_reg() instead of add_tsu_reg() in __sh_eth_get_regs() to dump it
causes EDMR or EDSR (depending on the register layout) to be dumped instead
of ARSTR. Use the correct condition/macro there...
Fixes: 6b4b4fead342 ("sh_eth: Implement ethtool register dump operations")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
drivers/net/ethernet/renesas/sh_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: net/drivers/net/ethernet/renesas/sh_eth.c
===================================================================
--- net.orig/drivers/net/ethernet/renesas/sh_eth.c
+++ net/drivers/net/ethernet/renesas/sh_eth.c
@@ -2089,8 +2089,8 @@ static size_t __sh_eth_get_regs(struct n
add_reg(CSMR);
if (cd->select_mii)
add_reg(RMII_MII);
- add_reg(ARSTR);
if (cd->tsu) {
+ add_tsu_reg(ARSTR);
add_tsu_reg(TSU_CTRST);
add_tsu_reg(TSU_FWEN0);
add_tsu_reg(TSU_FWEN1);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sh_eth: dix dumping ARSTR
2018-01-13 17:22 [PATCH] sh_eth: dix dumping ARSTR Sergei Shtylyov
@ 2018-01-13 17:23 ` Sergei Shtylyov
2018-01-13 18:18 ` Sergei Shtylyov
2018-01-15 19:51 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2018-01-13 17:23 UTC (permalink / raw)
To: netdev, linux-renesas-soc; +Cc: linux-sh
Forgot to say that the patch was against net.git.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sh_eth: dix dumping ARSTR
2018-01-13 17:23 ` Sergei Shtylyov
@ 2018-01-13 18:18 ` Sergei Shtylyov
0 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2018-01-13 18:18 UTC (permalink / raw)
To: netdev, linux-renesas-soc; +Cc: linux-sh
Umm, s/dix/fix/ in the subject. Do I need to repost?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sh_eth: dix dumping ARSTR
2018-01-13 17:22 [PATCH] sh_eth: dix dumping ARSTR Sergei Shtylyov
2018-01-13 17:23 ` Sergei Shtylyov
@ 2018-01-15 19:51 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2018-01-15 19:51 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: netdev, linux-renesas-soc, linux-sh
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Sat, 13 Jan 2018 20:22:01 +0300
> ARSTR is always located at the start of the TSU register region, thus
> using add_reg() instead of add_tsu_reg() in __sh_eth_get_regs() to dump it
> causes EDMR or EDSR (depending on the register layout) to be dumped instead
> of ARSTR. Use the correct condition/macro there...
>
> Fixes: 6b4b4fead342 ("sh_eth: Implement ethtool register dump operations")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Applied to 'net' with subj. typo fixed :)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-15 19:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-13 17:22 [PATCH] sh_eth: dix dumping ARSTR Sergei Shtylyov
2018-01-13 17:23 ` Sergei Shtylyov
2018-01-13 18:18 ` Sergei Shtylyov
2018-01-15 19:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).