From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev <netdev@vger.kernel.org>,
edumazet@google.com
Subject: Re: [PATCH v2] bpf: fix divides by zero
Date: Sun, 14 Jan 2018 09:08:24 -0800 [thread overview]
Message-ID: <20180114170822.sdqs2jreb3eaflsr@ast-mbp> (raw)
In-Reply-To: <1515807803.3606.7.camel@gmail.com>
On Fri, Jan 12, 2018 at 05:43:23PM -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> Divides by zero are not nice, lets avoid them if possible.
>
> Also do_div() seems not needed when dealing with 32bit operands,
> but this seems a minor detail.
>
> Fixes: bd4cf0ed331a ("net: filter: rework/optimize internal BPF interpreter's instruction set")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: syzbot <syzkaller@googlegroups.com>
> ---
Applied, Thank you Eric.
prev parent reply other threads:[~2018-01-14 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-13 1:33 [PATCH] bpf: fix divides by zero Eric Dumazet
2018-01-13 1:41 ` Eric Dumazet
2018-01-13 1:42 ` Alexei Starovoitov
2018-01-13 1:43 ` [PATCH v2] " Eric Dumazet
2018-01-14 17:08 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180114170822.sdqs2jreb3eaflsr@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox